calcite icon indicating copy to clipboard operation
calcite copied to clipboard
verified publisher icon apache

[CALCITE-6278] Add REGEXP, REGEXP_LIKE function (enabled in Spark library)

Open YiwenWu opened this issue 1 year ago • 5 comments

https://issues.apache.org/jira/browse/CALCITE-6278

  1. Add Function REGEXP、REGEXP_LIKE enabled in the Spark library. Since this function has the same implementation as the Spark RLIKE function. The implementation can be reused.

Source Code image

[undo] Discuss results in Jira:

  1. Since Spark 2.0, string literals (including regex patterns) are unescaped in SQL parser, also fix this bug in calcite.
  1. Add spark query tests in BabelQuidemTest to ensure the execution correctness.

YiwenWu avatar Mar 03 '24 02:03 YiwenWu

Would it be possible to merge these changes? I'm looking to implement CALCITE-6309 on top of this.

jduo avatar Mar 09 '24 23:03 jduo

Would it be possible to merge these changes? I'm looking to implement CALCITE-6309 on top of this.

@jduo I think this pr will be able to be merged recently, the details of the relevant issues have been discussed clearly in Jira.

YiwenWu avatar Mar 10 '24 06:03 YiwenWu

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 10 '24 06:03 sonarqubecloud[bot]

If no other comment, I will merge it later.

macroguo-ghy avatar Mar 11 '24 03:03 macroguo-ghy

If no other comment, I will merge it later.

Thanks, that'd be great. Once that's in I'll follow-up with the CALCITE-6309 work.

jduo avatar Mar 11 '24 23:03 jduo