calcite icon indicating copy to clipboard operation
calcite copied to clipboard

[CALCITE-4725] Between clause operands checker should check all combi…

Open paul8263 opened this issue 4 years ago • 3 comments

…nations of the three operands

What is the purpose of the change

Fix the issue that between clause operands checker should check all combinations of the three operands, as what has been discuss in CALCITE-4725 in ASF Jira.

Brief change log

  • core/src/main/java/org/apache/calcite/sql/type/SameOperandTypeChecker.java
  • core/src/main/java/org/apache/calcite/sql/type/SameOperandTypeExceptLastOperandChecker.java

paul8263 avatar Aug 11 '21 07:08 paul8263

@paul8263 please add unit test in this patch.

NobiGo avatar Aug 11 '21 08:08 NobiGo

Hi @NobiGo , Thank you for your advice. Unit test has been added and several errors have been fixed.

paul8263 avatar Aug 12 '21 02:08 paul8263

Hi @NobiGo , Could you please help review this issue?

paul8263 avatar Mar 21 '22 01:03 paul8263

I plan to review this PR. It looks like BETWEEN cannot currently compare TIMESTAMPS, for example

mihaibudiu avatar Aug 23 '24 07:08 mihaibudiu