brooklyn-server icon indicating copy to clipboard operation
brooklyn-server copied to clipboard

Adds a policy to create locations from an entity

Open grkvlt opened this issue 8 years ago • 8 comments

Adds CreateLocationPolicywhich configures a location using sensor data from an entity, once the entity is running. The location is added to the catalog for use by other blueprints.

grkvlt avatar Jun 29 '17 15:06 grkvlt

This looks really useful but it could probably do with some tests if that's possible @grkvlt?

drigodwin avatar Jun 29 '17 16:06 drigodwin

Yes, that's true - I'll put something together

grkvlt avatar Jun 29 '17 16:06 grkvlt

I agree with @drigodwin about the tests :)

FYI I've tested the CreateLocationPolicy and it works fine in some scenarios, only a minor comment.

andreaturli avatar Jun 30 '17 09:06 andreaturli

@grkvlt any updates on this?

andreaturli avatar Jul 19 '17 08:07 andreaturli

Thanks for the review @aledsage, I will update appropriately. The use case is for blueprints like Kubernetes, which would be able to add a new KubernetesLocation or similar.

grkvlt avatar Sep 13 '17 17:09 grkvlt

@grkvlt Did you had the time to look at @aledsage's comments for this PR?

tbouron avatar Nov 22 '17 14:11 tbouron

@grkvlt Could you look at @aledsage comments please? Would be great to merge this PR 👍

tbouron avatar Aug 30 '18 12:08 tbouron

@grkvlt Could you take a look at this to see if it's still relevant, and address the comments please

Thanks

nakomis avatar Nov 26 '19 11:11 nakomis