brooklyn-server icon indicating copy to clipboard operation
brooklyn-server copied to clipboard

Update IPTables save method

Open frogfather opened this issue 7 years ago • 7 comments

Service iptables save doesn't work with Centos7

frogfather avatar Oct 01 '18 13:10 frogfather

Service iptables save doesn't work with Centos7

That is, doesn't work with the CentOS 7 AMI we use on EC2, which has a cut-down service command only supporting the standard start, stop, restart and status command verbs.

grkvlt avatar Oct 02 '18 13:10 grkvlt

Thanks @frogfather LGTM, will merge assuming tests pass

grkvlt avatar Oct 02 '18 13:10 grkvlt

I think Jenkins is failing due to permissions, maybe on the ASF side?

grkvlt avatar Oct 02 '18 18:10 grkvlt

LGTM; happy for this to be merged (once confusion with the identical-looking https://github.com/apache/brooklyn-server/pull/1006 is cleared up).

aledsage avatar Oct 09 '18 18:10 aledsage

as @aledsage this is largely included in #1006 . @frogfather your call whether there is value in the recent comments here and if so update this PR, make sure to git merge master in to this branch, or if not just close this.

ahgittin avatar Nov 23 '18 12:11 ahgittin

@frogfather Can you take a look at this please to see if it is still relevant, and address the comments above if appropriate

Thanks

nakomis avatar Nov 26 '19 11:11 nakomis

Will do. It looks like #1006 (which was similar) was closed.

Sent from my iPhone

On 26 Nov 2019, at 11:40, Martin Harris [email protected] wrote:

 @frogfather Can you take a look at this please to see if it is still relevant, and address the comments above if appropriate

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

frogfather avatar Nov 26 '19 12:11 frogfather