BookieNettyServer#listenOn netty WRITE_BUFFER_WATER_MARK setting does not take effect

Open keyboardbobo opened this issue 2 years ago • 2 comments

BUG REPORT

Describe the bug

bootstrap.option(ChannelOption.WRITE_BUFFER_WATER_MARK, new WriteBufferWaterMark(
                    conf.getServerWriteBufferLowWaterMark(), conf.getServerWriteBufferHighWaterMark()));

should be :

            bootstrap.childOption(ChannelOption.WRITE_BUFFER_WATER_MARK, new WriteBufferWaterMark(
                    conf.getServerWriteBufferLowWaterMark(), conf.getServerWriteBufferHighWaterMark()));

Instead of setting the parameters of option, set the parameters of childOption. Otherwise it will not take effect

Oct 17 '23 07:10 keyboardbobo

Instead of setting the parameters of option, set the parameters of childOption. Otherwise it will not take effect

@keyboardbobo Yes that's correct. Have you run across a problem that this has caused?

Feb 09 '24 10:02 lhotari

The impact of this bug is that the Netty defaults have been used (low 32kB, high 64kB) instead of the expected defaults low 384kB high 512kB.

Feb 09 '24 11:02 lhotari