bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard
verified publisher icon apache

add log's dependency for bookkeeper-dist-server

Open StevenLuMT opened this issue 3 years ago • 6 comments

Descriptions of the changes in this PR:

Motivation

like pulsar's distribution/server add log's dependency in bookkeeper-dist/server

Changes

  1. add log's dependency in bookkeeper-dist/server/pom.xml
  2. then auto add log's dependency to bookkeeper-server-..*-SNAPSHOT-bin.tar.gz

StevenLuMT avatar Sep 05 '22 11:09 StevenLuMT

I am confused too. why we need this dependency ? We can print log well for now. Do you want to support Async log on bookkeeper?

cc @eolivelli

hezhangjian avatar Sep 12 '22 00:09 hezhangjian

Do you want to support Async log on bookkeeper?

yes, this pr's motivation is to support async log @Shoothzj

StevenLuMT avatar Sep 14 '22 01:09 StevenLuMT

rerun failure checks

StevenLuMT avatar Sep 20 '22 11:09 StevenLuMT

Why we need add log4j-1.2-api dependency?

@Shoothzj Legacy Log4j 1.2 API , it's the dependency in org.apache.logging.log4j.log4j-bom

image

StevenLuMT avatar Sep 20 '22 11:09 StevenLuMT

@StevenLuMT of course it's defined in the bom, but it's not the reason we put it in our dependency! I didn't see any usage of log4j1 in bookkeeper.

hezhangjian avatar Sep 20 '22 14:09 hezhangjian

@StevenLuMT of course it's defined in the bom, but it's not the reason we put it in our dependency! I didn't see any usage of log4j1 in bookkeeper.

good catch, log4j-1.2-api is no use in project, I misunderstood,thanks very much @Shoothzj

StevenLuMT avatar Sep 20 '22 15:09 StevenLuMT

closed by #4269 thanks for your initiation contribution.

hezhangjian avatar Apr 11 '24 10:04 hezhangjian