bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard

Add skip remove bookie option for bookkeeper shell recover command

Open StevenLuMT opened this issue 4 years ago • 3 comments

Descriptions of the changes in this PR:

Motivation

  1. the bookie's machine is broken, when the ledger's status is IN_RECOVERY, the autorecovery and old recover tool (you can run with this command: bin/bookkeeper shell recover) couldn't solve these ledgers in IN_RECOVERY.
  2. I develop these code in branch-4.14 to recover these ledgers in IN_RECOVERY
  3. then I find a same pr #2870 ,but I think mine codes are more accurate to solve this problem

Changes

1.add RecoverCommand's function skipRemoveBookieStatus (just skip remove bookie's status to revover the others bookie's data) 2.add param(named skipRemoveBookieStatus) in client API in LedgerOpenOp/LedgerRecoveryOp/PendingReadLacOp/PendingReadOp/ReadLastConfirmedOp

StevenLuMT avatar Dec 26 '21 13:12 StevenLuMT

Could you please give me more details of this PR?

@zymap case when a bookie node is down and the machine cannot be repaired:

The ledger in IN_RECOVERY status cann't be auto recovery successfully, so we add this function to recover this ledger.

StevenLuMT avatar Dec 29 '21 03:12 StevenLuMT

@nicoloboschi @dlg99 @eolivelli @zymap If you have time, please help me review it, thank you

StevenLuMT avatar Jan 02 '22 13:01 StevenLuMT

@hangc0276 Could you please take a look as well? Because it looks like is an improvement of the skip unrecoverable ledger.

zymap avatar Jan 04 '22 02:01 zymap