beam icon indicating copy to clipboard operation
beam copied to clipboard

Kafka poll interval

Open Naireen opened this issue 1 year ago • 2 comments

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Naireen avatar Aug 12 '24 21:08 Naireen

Run Java_Kafka_IO_Direct PreCommit

Naireen avatar Aug 27 '24 20:08 Naireen

Run Java_Kafka_IO_Direct PreCommit

Abacn avatar Aug 28 '24 01:08 Abacn

Test is failing for kafka versions prior to 2.x.x

Naireen avatar Sep 03 '24 20:09 Naireen

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java. R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Sep 26 '24 02:09 github-actions[bot]

This change makes a bunch of sense if the theory is true. Do we have a plan on how to verify that the theory is correct?

johnjcasey avatar Oct 02 '24 17:10 johnjcasey

I have done some testing, , and with the added monitoring metrics once (https://github.com/apache/beam/pull/32402) goes in, we can get better metrics for additional validation

Comparing these two jobs

  1. we have throughput at 25 mb/s with input at 60 mb/s, so it falls behind, which degrades to below to 10 when p99 is ~ 4 seconds
  2. we have throughput at 60 mb/s (with the same input), so it keeps up until P99.9 for latency of active user op reaches ~8 seconds, throughput drops again (but recovers when it goes down again) , so its more robust

This testing is a bout a month old though

Naireen avatar Oct 03 '24 17:10 Naireen

R: @scwhittle

Naireen avatar Oct 03 '24 17:10 Naireen

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

github-actions[bot] avatar Oct 03 '24 17:10 github-actions[bot]

Hi @Naireen , is this still being worked on?

claudevdm avatar Nov 18 '24 15:11 claudevdm

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Jan 18 '25 12:01 github-actions[bot]

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Jan 25 '25 12:01 github-actions[bot]