beam icon indicating copy to clipboard operation
beam copied to clipboard

[WIP] Add in redistribute option for Kafka Read

Open Naireen opened this issue 1 year ago • 2 comments

Add option to enable Kafka Read with redistribute afterwards to increase paralellism


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Naireen avatar May 20 '24 18:05 Naireen

Run Python_PVR_Flink PreCommit

Naireen avatar May 22 '24 20:05 Naireen

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.41%. Comparing base (5c30b1d) to head (4ada08d). Report is 122 commits behind head on master.

:exclamation: Current head 4ada08d differs from pull request most recent head f7c1974

Please upload reports for the commit f7c1974 to get more accurate results.

Files Patch % Lines
sdks/python/apache_beam/io/kafka.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #31347       +/-   ##
=============================================
+ Coverage     68.55%   71.41%    +2.86%     
+ Complexity    14921     1474    -13447     
=============================================
  Files          2636      910     -1726     
  Lines        222080   113845   -108235     
  Branches      11825     1076    -10749     
=============================================
- Hits         152238    81299    -70939     
+ Misses        63647    30526    -33121     
+ Partials       6195     2020     -4175     
Flag Coverage Δ
python 81.37% <0.00%> (-0.10%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 24 '24 22:05 codecov[bot]

Run Java_Examples_Dataflow PreCommit

Naireen avatar May 28 '24 20:05 Naireen

Run Yaml_Xlang_Direct PreCommit

Naireen avatar May 28 '24 21:05 Naireen

Run Yaml_Xlang_Direct PreCommit

Naireen avatar May 28 '24 22:05 Naireen

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar May 28 '24 22:05 github-actions[bot]

@reviewers

Will periodically repeat current tests, but failures look unrelated to current changes (example workflow is failling due to oath issues + unable to find source files for tests + issues with translation beam:external:java:sql:v1)

Naireen avatar May 28 '24 22:05 Naireen

Run Yaml_Xlang_Direct PreCommit

Naireen avatar May 29 '24 17:05 Naireen

Run Java_Examples_Dataflow PreCommit

Naireen avatar May 29 '24 17:05 Naireen

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python. R: @damondouglas for label java. R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar May 31 '24 07:05 github-actions[bot]

Reminder, please take a look at this pr: @damccorm @damondouglas @shunping

github-actions[bot] avatar Jun 12 '24 12:06 github-actions[bot]

R: @kennknowles

damccorm avatar Jun 14 '24 11:06 damccorm

(since you've started the review, I'm inclined to keep it sticky/stop the bot - feel free to say otherwise if appropriate)

damccorm avatar Jun 14 '24 11:06 damccorm

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar Jun 14 '24 12:06 github-actions[bot]

Agree, keep it sticky.

kennknowles avatar Jun 14 '24 15:06 kennknowles