Remove GlobalWindows for unbounded pcoll without a default global window
Fixes #25598
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead. - [ ] Update
CHANGES.mdwith noteworthy changes. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.
Codecov Report
Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.
Project coverage is 71.45%. Comparing base (
c061b27) to head (a20235c). Report is 44 commits behind head on master.
:exclamation: Current head a20235c differs from pull request most recent head 1b8d9c6
Please upload reports for the commit 1b8d9c6 to get more accurate results.
| Files | Patch % | Lines |
|---|---|---|
| sdks/python/apache_beam/io/iobase.py | 66.66% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #30728 +/- ##
============================================
+ Coverage 71.43% 71.45% +0.02%
============================================
Files 909 710 -199
Lines 113707 104799 -8908
Branches 1076 0 -1076
============================================
- Hits 81229 74889 -6340
+ Misses 30453 28275 -2178
+ Partials 2025 1635 -390
| Flag | Coverage Δ | |
|---|---|---|
| java | ? |
|
| python | 81.23% <66.66%> (-0.19%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Need more time to test this with DataflowRunner.
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
Dataflow still fails with:
Detailed information (job=2024-11-24_13_19_52-13228784541511173196): generic::internal: Two main read operations have the same transform user name: WriteToText/Write/WriteImpl/DoOnce/Map(decode).None/FromValue/ReadStream
with MessageCode:
(19ebbab49bb22ab3): Workflow failed.
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.