beam icon indicating copy to clipboard operation
beam copied to clipboard
verified publisher icon apache

Feature/add error handling for bqio

Open johnjcasey opened this issue 2 years ago • 6 comments

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

johnjcasey avatar Jan 23 '24 16:01 johnjcasey

Run Java PostCommit

johnjcasey avatar Jan 23 '24 17:01 johnjcasey

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Feb 09 '24 17:02 github-actions[bot]

"beam_PostCommit_Java" runs non-IO integration tests on direct runner. Would you mind trigger Dataflow PostCommit (which runs GCP IO integraiton tests on Dataflow) by adding file namedbeam_PostCommit_Java_DataflowV1.json ?

Abacn avatar Feb 14 '24 15:02 Abacn

I went through the changes and mostly looks straightforward and looks good to me. Due to the large number of line of changes I may missed something. Please run postcommit tests and see we do not break things (commented above). Also consider run Python xlang GCPIO Dataflow (trigger path beam_PostCommit_Python_Xlang_Gcp_Dataflow.json)

Abacn avatar Feb 14 '24 17:02 Abacn

There are integration test failed:

org.apache.beam.sdk.io.gcp.bigquery.BigQueryIOStorageReadIT > testBigQueryStorageRead1MErrorHandlingArrow FAILED
    java.lang.RuntimeException at BigQueryIOStorageReadIT.java:162

org.apache.beam.sdk.io.gcp.bigquery.BigQueryIOStorageReadIT > testBigQueryStorageRead1MErrorHandlingAvro FAILED
    java.lang.RuntimeException at BigQueryIOStorageReadIT.java:162

See https://github.com/apache/beam/runs/21587463679 for details

Abacn avatar Feb 15 '24 16:02 Abacn

"beam_PostCommit_Java" runs non-IO integration tests on direct runner. Would you mind trigger Dataflow PostCommit (which runs GCP IO integraiton tests on Dataflow) by adding file namedbeam_PostCommit_Java_DataflowV1.json ?

Turns out the tests hadn't gotten run, and I missed something. Thanks for the catch!

johnjcasey avatar Feb 15 '24 17:02 johnjcasey

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas for label java. R: @damccorm for label build. R: @damondouglas for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Feb 20 '24 23:02 github-actions[bot]