beam icon indicating copy to clipboard operation
beam copied to clipboard

[#22660] Upgrade org.apache.samza to 1.7

Open kw2542 opened this issue 3 years ago • 22 comments

  1. Upgrade org.apache.samza to 1.7
  2. Enhance SamzaServerConfiguration to be configurable of base dir for states in order to isolate dir for different jobs to avoid state conflict.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Choose reviewer(s) and mention them in a comment (R: @username).
  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI.

kw2542 avatar Aug 11 '22 15:08 kw2542

Run Java Samza PortableValidatesRunner

kw2542 avatar Aug 12 '22 18:08 kw2542

Run Samza ValidatesRunner

kw2542 avatar Aug 12 '22 18:08 kw2542

Run Python Samza ValidatesRunner

kw2542 avatar Aug 12 '22 18:08 kw2542

Run XVR_Samza PostCommit

kw2542 avatar Aug 12 '22 18:08 kw2542

Run Go Samza ValidatesRunner

kw2542 avatar Aug 12 '22 18:08 kw2542

Run Python Samza ValidatesRunner

kw2542 avatar Aug 12 '22 22:08 kw2542

Codecov Report

Merging #22693 (1a9886b) into master (cf9ea1f) will decrease coverage by 0.13%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #22693      +/-   ##
==========================================
- Coverage   74.20%   74.06%   -0.14%     
==========================================
  Files         708      715       +7     
  Lines       93473    95012    +1539     
==========================================
+ Hits        69357    70371    +1014     
- Misses      22841    23366     +525     
  Partials     1275     1275              
Flag Coverage Δ
python 83.20% <ø> (-0.41%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/typehints/__init__.py 77.77% <0.00%> (-22.23%) :arrow_down:
...ks/python/apache_beam/runners/worker/statecache.py 89.69% <0.00%> (-6.47%) :arrow_down:
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) :arrow_down:
...dks/python/apache_beam/metrics/monitoring_infos.py 92.50% <0.00%> (-4.50%) :arrow_down:
...examples/inference/sklearn_mnist_classification.py 43.75% <0.00%> (-3.75%) :arrow_down:
sdks/python/apache_beam/internal/pickler.py 92.00% <0.00%> (-3.46%) :arrow_down:
...python/apache_beam/runners/worker/worker_status.py 76.66% <0.00%> (-3.05%) :arrow_down:
...che_beam/runners/interactive/interactive_runner.py 90.06% <0.00%> (-1.33%) :arrow_down:
sdks/python/apache_beam/dataframe/schemas.py 96.62% <0.00%> (-1.01%) :arrow_down:
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) :arrow_down:
... and 44 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 12 '22 22:08 codecov[bot]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python. R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Aug 12 '22 23:08 github-actions[bot]

Run Java PreCommit

kw2542 avatar Aug 13 '22 01:08 kw2542

The Go ValidatesRunner suite seems to be failing with timeouts for each test.

jrmccluskey avatar Aug 19 '22 17:08 jrmccluskey

Run Go Samza ValidatesRunner

kw2542 avatar Sep 06 '22 20:09 kw2542

Run Go Samza ValidatesRunner

kw2542 avatar Sep 07 '22 21:09 kw2542

Run Go PreCommit

kw2542 avatar Sep 07 '22 21:09 kw2542

Run Java Samza PortableValidatesRunner

kw2542 avatar Sep 07 '22 21:09 kw2542

Run Samza ValidatesRunner

kw2542 avatar Sep 07 '22 21:09 kw2542

Run Python Samza ValidatesRunner

kw2542 avatar Sep 07 '22 21:09 kw2542

Run XVR_Samza PostCommit

kw2542 avatar Sep 08 '22 19:09 kw2542

Reminder, please take a look at this pr: @AnandInguva @jrmccluskey

github-actions[bot] avatar Sep 16 '22 12:09 github-actions[bot]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @y1chi for label python. R: @lostluck for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions[bot] avatar Sep 20 '22 12:09 github-actions[bot]

Run XVR_Samza PostCommit

kw2542 avatar Sep 21 '22 18:09 kw2542

Run Go PreCommit

kw2542 avatar Sep 21 '22 18:09 kw2542

Run Python PreCommit

kw2542 avatar Sep 21 '22 18:09 kw2542