beam icon indicating copy to clipboard operation
beam copied to clipboard

[BEAM-14118, fixes #21639] Use vendored gRPC 1.48.1

Open lukecwik opened this issue 3 years ago • 7 comments

This change:

  • swaps java imports
  • fixes a new deprecation issue TextFormat.printToString -> TextFormat.printer().printToString caused by the update
  • deletes the old 1.43.2 package

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Choose reviewer(s) and mention them in a comment (R: @username).
  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI.

lukecwik avatar Aug 08 '22 23:08 lukecwik

R: @emilymye @jigga

lukecwik avatar Aug 08 '22 23:08 lukecwik

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

github-actions[bot] avatar Aug 08 '22 23:08 github-actions[bot]

Codecov Report

Merging #22628 (e55698b) into master (1f2186d) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #22628      +/-   ##
==========================================
- Coverage   74.20%   74.19%   -0.02%     
==========================================
  Files         708      708              
  Lines       93462    93462              
==========================================
- Hits        69355    69342      -13     
- Misses      22832    22845      +13     
  Partials     1275     1275              
Flag Coverage Δ
python 83.59% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) :arrow_down:
...che_beam/runners/interactive/interactive_runner.py 90.06% <0.00%> (-1.33%) :arrow_down:
sdks/python/apache_beam/io/localfilesystem.py 90.97% <0.00%> (-0.76%) :arrow_down:
...eam/runners/portability/fn_api_runner/execution.py 92.44% <0.00%> (-0.65%) :arrow_down:
sdks/python/apache_beam/runners/direct/executor.py 96.46% <0.00%> (-0.55%) :arrow_down:
...ks/python/apache_beam/runners/worker/sdk_worker.py 88.94% <0.00%> (-0.16%) :arrow_down:
sdks/python/apache_beam/transforms/util.py 96.06% <0.00%> (-0.16%) :arrow_down:
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (-0.13%) :arrow_down:
...eam/runners/interactive/interactive_environment.py 92.02% <0.00%> (+0.30%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Aug 08 '22 23:08 codecov[bot]

Run Spotless PreCommit

lukecwik avatar Aug 09 '22 00:08 lukecwik

Run SQL PreCommit

lukecwik avatar Aug 09 '22 00:08 lukecwik

Run Java_Examples_Dataflow PreCommit

lukecwik avatar Aug 09 '22 00:08 lukecwik

Run Java_Examples_Dataflow PreCommit

lukecwik avatar Aug 09 '22 00:08 lukecwik

~Seems it breaks Java Wordcount Dataflow github action: https://github.com/apache/beam/runs/7774388676?check_suite_focus=true~ never mind, this one was flake; failure is due to another issue.

Abacn avatar Aug 11 '22 17:08 Abacn