beam icon indicating copy to clipboard operation
beam copied to clipboard
verified publisher icon apache

[CdapIO] Integration CdapIO with SparkReceiverIO

Open Amar3tto opened this issue 3 years ago • 2 comments

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Choose reviewer(s) and mention them in a comment (R: @username).
  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI.

Amar3tto avatar Aug 04 '22 11:08 Amar3tto

Run Java PreCommit

Amar3tto avatar Sep 19 '22 05:09 Amar3tto

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lukecwik for label java. R: @Abacn for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Sep 20 '22 17:09 github-actions[bot]

@chamikaramj @aromanenko-dev [CdapIO] Integration CdapIO with SparkReceiverIO PR is ready for review Thank you!

elizaveta-lomteva avatar Sep 22 '22 15:09 elizaveta-lomteva

@chamikaramj @aromanenko-dev kindly remind you that PR is ready for the review :)

elizaveta-lomteva avatar Oct 05 '22 15:10 elizaveta-lomteva

Run RAT PreCommit

Amar3tto avatar Oct 07 '22 15:10 Amar3tto

Run Java_Examples_Dataflow PreCommit

Amar3tto avatar Oct 07 '22 18:10 Amar3tto

@aromanenko-dev @chamikaramj @mosche All your comments have been addressed. Can we consider this PR ready for merge?

elizaveta-lomteva avatar Oct 12 '22 14:10 elizaveta-lomteva

@chamikaramj @mosche Do you have additional comments on this PR?

aromanenko-dev avatar Oct 18 '22 14:10 aromanenko-dev

LGTM @aromanenko-dev Though - unrelated - one more question @Lizzfox, what's the purpose / importance of Spark in the picture here? We're actually preparing the removal of the deprecated Spark2 runner (asap). The runner is badly broken and not usable anymore due to a Jackson dependency conflict (see #23568). Unfortunately this wasn't caught in local tests, but only if submitting a job to a Spark 2.4 cluster. Does this impact you?

mosche avatar Oct 18 '22 14:10 mosche

@mosche we don't use Spark runner, we only support Dataflow runner in our implementation. Thanks

elizaveta-lomteva avatar Oct 19 '22 14:10 elizaveta-lomteva