avro icon indicating copy to clipboard operation
avro copied to clipboard

[AVRO-2773] Added support for logical types in C

Open mispecto opened this issue 5 years ago • 23 comments

AVRO-2773

mispecto avatar Mar 10 '20 11:03 mispecto

Hey guys, how about getting this merged.

xmcqueen avatar Jun 24 '20 17:06 xmcqueen

i was looking at that again just this morning! thanks

xmcqueen avatar Jun 29 '20 20:06 xmcqueen

I'm not sure these CI build errors are related.

mispecto avatar Jul 07 '20 17:07 mispecto

@spektom can you rebase against latest master?

Fokko avatar Aug 19 '20 18:08 Fokko

@Fokko build errors seem unrelated still.

mispecto avatar Aug 20 '20 05:08 mispecto

@Fokko tried again merging from master, I hope this time there won't be build issues.

mispecto avatar Aug 25 '20 11:08 mispecto

Hi, what is preventing this from being merged ? It would be very nice to have logical type support in the C library.

gscteam avatar Dec 17 '20 14:12 gscteam

I've not noticed any real owner for this project. Does this project have an owner anymore?

xmcqueen avatar Dec 17 '20 19:12 xmcqueen

Does it need an owner to get it merged? Is the owner the coder ? or is this related to the jira issue ?

gscteam avatar Dec 18 '20 03:12 gscteam

Does it need an owner to get it merged? Is the owner the coder ? or is this related to the jira issue ?

No, I'm not the owner. The PR is waiting for a review from @thiru-mg

mispecto avatar Dec 18 '20 04:12 mispecto

It seems that the reviewer is unresponsive, could we assign a new one ?

gscteam avatar Dec 23 '20 16:12 gscteam

@gscteam Please vote on the issue: https://issues.apache.org/jira/plugins/servlet/mobile#issue/AVRO-2773

mispecto avatar Dec 23 '20 16:12 mispecto

I am interested in this as well.

wccropper avatar Jan 06 '21 16:01 wccropper

I am interested in this as well.

Please vote on the issue: https://issues.apache.org/jira/plugins/servlet/mobile#issue/AVRO-2773

mispecto avatar Jan 07 '21 06:01 mispecto

Thanks. I voted. Let's all get the votes going over here: https://issues.apache.org/jira/browse/AVRO-2773

xmcqueen avatar Jan 07 '21 17:01 xmcqueen

Likewise, voted 👍

methodmissing avatar Jan 09 '21 18:01 methodmissing

Any chance to get this merged ?

maver1ck avatar Aug 05 '21 12:08 maver1ck

Any progress about this?

kensou97 avatar Jan 23 '24 06:01 kensou97

Any progress about this?

IMO, the best you can do is vote for this fix here: https://issues.apache.org/jira/plugins/servlet/mobile#issue/AVRO-2773 This should probably motivate project owners to consider reviewing the PR.

mispecto avatar Jan 23 '24 06:01 mispecto

I will close/reopen the PR to trigger the CI checks. But I have no experience with the C SDK to be able to review and merge it!

martin-g avatar Jan 23 '24 08:01 martin-g

Since there is no active maintainer of the C SDK I'd propose that at least two users/contributors review, test and approve this PR! Then I could merge it for you!

martin-g avatar Jan 23 '24 09:01 martin-g

@mkmkme @SahilKang Would you be interested in reviewing/testing this PR ? Thank you!

martin-g avatar Mar 12 '24 11:03 martin-g

Hey @martin-g ! I can test it, but it'll take some time.

mkmkme avatar Mar 12 '24 11:03 mkmkme