arrow icon indicating copy to clipboard operation
arrow copied to clipboard

ARROW-18128: [Java][CI] Update timestamp of Java Nightlies X.Y.Z-SNAPSHOT folder

Open raulcd opened this issue 3 years ago • 6 comments

raulcd avatar Oct 25 '22 10:10 raulcd

@kou I have tested locally and this should fix the issue. I can't sync the nightlies repository, as I don't have access to be able to rsync. Let me know if this makes sense to you or if there is something you think I could do to test this out.

raulcd avatar Oct 25 '22 10:10 raulcd

https://issues.apache.org/jira/browse/ARROW-18128

github-actions[bot] avatar Oct 25 '22 11:10 github-actions[bot]

I tried this locally but I noticed that there are no 2022-09-XX directories in https://nightlies.apache.org/arrow/java/org/apache/arrow/arrow-vector/ now.

It seems that https://github.com/apache/arrow/actions/runs/3298113920/jobs/5439805962 removes 2022-09-21 and https://github.com/apache/arrow/actions/runs/3303520952/jobs/5451532542 removes 2022-09-22.

It seems that the current prune implementation works well. It seems that the current build repository implementation has a problem.

For example, 2022-10-01 https://github.com/apache/arrow/actions/runs/3164856433/jobs/5153450720 failed to build repository https://github.com/apache/arrow/actions/runs/3164856433/jobs/5153450720#step:11:28 (ls: cannot access 'binaries/nightly-packaging-20***-10-01-0/java-jars': No such file or directory) because java-jars nightly job failed https://lists.apache.org/thread/z8h8bbhjrzpxdlp5ko6sp1tv7bjnmosh .

kou avatar Oct 27 '22 05:10 kou

Ok, it seems that the 10.0.0-SNAPSHOT and 11.0.0-SNAPSHOT are now published on the repo for all the jobs that didn't had it previously, like: https://nightlies.apache.org/arrow/java/org/apache/arrow/arrow-memory/ or https://nightlies.apache.org/arrow/java/org/apache/arrow/flight-core/ they were created on the 20th/21st of October respectively which is 1 day after the original ticket was created. Apart from the issue you are pointing out, I think the problem is that we are not republishing them every day and we remove them once they are 14 days old and there's one day where they are missing. Does that makes sense @kou ?

raulcd avatar Oct 27 '22 09:10 raulcd

Ah, how about updating timestamp of the X.Y.Z-SNAPSHOT directory when we update artifacts under the X.Y.Z-SNAPSHOT directory?

diff --git a/.github/workflows/java_nightly.yml b/.github/workflows/java_nightly.yml
index b47306eec8..c9b9ba1d71 100644
--- a/.github/workflows/java_nightly.yml
+++ b/.github/workflows/java_nightly.yml
@@ -110,6 +110,7 @@ jobs:
           for LIBRARY in $(ls binaries/$PREFIX/java-jars | grep -E '.jar|.pom' | grep SNAPSHOT); do
             [[ $LIBRARY =~ $PATTERN_TO_GET_LIB_AND_VERSION ]]
             mkdir -p repo/org/apache/arrow/${BASH_REMATCH[1]}/${BASH_REMATCH[2]}
+            touch repo/org/apache/arrow/${BASH_REMATCH[1]}/${BASH_REMATCH[2]}
             mkdir -p repo/org/apache/arrow/${BASH_REMATCH[1]}/${DATE}
             # Copy twice to maintain a latest snapshot and some earlier versions
             cp binaries/$PREFIX/java-jars/$LIBRARY repo/org/apache/arrow/${BASH_REMATCH[1]}/${BASH_REMATCH[2]}

kou avatar Oct 27 '22 21:10 kou

Thanks @kou that makes sense. I've reverted the previous change and have applied the touch command to update the timestamp on those folders.

raulcd avatar Oct 28 '22 16:10 raulcd

Benchmark runs are scheduled for baseline = f57ad932664d50444880e54f18e31b1ce1adf1ef and contender = 02d4af1116d2403680fc7f9ce63ca29402e27b77. 02d4af1116d2403680fc7f9ce63ca29402e27b77 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. Conbench compare runs links: [Finished :arrow_down:0.0% :arrow_up:0.0%] ec2-t3-xlarge-us-east-2 [Failed :arrow_down:0.0% :arrow_up:0.0%] test-mac-arm [Finished :arrow_down:0.0% :arrow_up:0.0%] ursa-i9-9960x [Finished :arrow_down:0.18% :arrow_up:0.0%] ursa-thinkcentre-m75q Buildkite builds: [Finished] 02d4af11 ec2-t3-xlarge-us-east-2 [Failed] 02d4af11 test-mac-arm [Finished] 02d4af11 ursa-i9-9960x [Finished] 02d4af11 ursa-thinkcentre-m75q [Finished] f57ad932 ec2-t3-xlarge-us-east-2 [Failed] f57ad932 test-mac-arm [Finished] f57ad932 ursa-i9-9960x [Finished] f57ad932 ursa-thinkcentre-m75q Supported benchmarks: ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True test-mac-arm: Supported benchmark langs: C++, Python, R ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

ursabot avatar Oct 30 '22 03:10 ursabot