arrow icon indicating copy to clipboard operation
arrow copied to clipboard

ARROW-17192: [Python] Pass **kwargs in read_feather to to_pandas()

Open AlenkaF opened this issue 3 years ago • 5 comments

Pass **kwargs in read_feather to to_pandas() to ensure timestamp_as_object=True (together with other **kwargs) can be passed and the conversion between Arrow and pandas doesn't fail due to different datetime resolutions.

AlenkaF avatar Oct 25 '22 07:10 AlenkaF

https://issues.apache.org/jira/browse/ARROW-17192

github-actions[bot] avatar Oct 25 '22 09:10 github-actions[bot]

@AlenkaF feel free to merge once CI is fixed and you can update here to get green CI

jorisvandenbossche avatar Oct 25 '22 13:10 jorisvandenbossche

The release jobs keep failing even after rebasing, the MacOs failure has a Jira: https://issues.apache.org/jira/browse/ARROW-18150.

None of these failures seem to be connected to this PR.

AlenkaF avatar Oct 26 '22 17:10 AlenkaF

Updated test looks good! There is still the data file committed though, that can be removed now

jorisvandenbossche avatar Oct 27 '22 16:10 jorisvandenbossche

OK, this should be ready now. Can merge when the CI is green.

AlenkaF avatar Oct 28 '22 04:10 AlenkaF

Benchmark runs are scheduled for baseline = 94cf74f3b5b58a0bb45e7123ea907f2f21319776 and contender = 28a1152a5b0a5a58bcf24bdfd6aea54ee7282360. 28a1152a5b0a5a58bcf24bdfd6aea54ee7282360 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. Conbench compare runs links: [Finished :arrow_down:0.0% :arrow_up:0.0%] ec2-t3-xlarge-us-east-2 [Finished :arrow_down:0.37% :arrow_up:0.03%] test-mac-arm [Finished :arrow_down:0.27% :arrow_up:0.0%] ursa-i9-9960x [Finished :arrow_down:0.6% :arrow_up:0.0%] ursa-thinkcentre-m75q Buildkite builds: [Finished] 28a1152a ec2-t3-xlarge-us-east-2 [Finished] 28a1152a test-mac-arm [Finished] 28a1152a ursa-i9-9960x [Finished] 28a1152a ursa-thinkcentre-m75q [Finished] 94cf74f3 ec2-t3-xlarge-us-east-2 [Finished] 94cf74f3 test-mac-arm [Finished] 94cf74f3 ursa-i9-9960x [Finished] 94cf74f3 ursa-thinkcentre-m75q Supported benchmarks: ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True test-mac-arm: Supported benchmark langs: C++, Python, R ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

ursabot avatar Nov 09 '22 23:11 ursabot

Thank you very much @AlenkaF !

adrienpacifico avatar Nov 14 '22 09:11 adrienpacifico