arrow icon indicating copy to clipboard operation
arrow copied to clipboard

ARROW-17207: [C++][CI] Occasional timeout failures on arrow-compute-scalar-test

Open westonpace opened this issue 3 years ago • 7 comments

westonpace avatar Oct 21 '22 00:10 westonpace

https://issues.apache.org/jira/browse/ARROW-17207

github-actions[bot] avatar Oct 21 '22 00:10 github-actions[bot]

:warning: Ticket has not been started in JIRA, please click 'Start Progress'.

github-actions[bot] avatar Oct 21 '22 00:10 github-actions[bot]

No single test dominates the execution time. There are just a lot of tests. None of the tests appear to use threads. When run with TSAN the tests are slower but the additional load appears evenly distributed across tests.

Splitting into two tests seems like the simplest approach for now.

westonpace avatar Oct 21 '22 00:10 westonpace

While the approach here is sane, perhaps we can try profiling this with TSAN enabled to see if there obvious optimizations to do in our test routines?

(another possibility might be to enable some compiler optimizations when building with TSAN, I don't think how safe/reasonable that is)

pitrou avatar Oct 22 '22 14:10 pitrou

Alternative is to simply bump the timeout a bit: https://github.com/apache/arrow/pull/14502

pitrou avatar Oct 25 '22 16:10 pitrou

Now that https://github.com/apache/arrow/pull/14502 is merged, I think we can close this.

pitrou avatar Oct 26 '22 07:10 pitrou

Note I also profiled as I suggested above (albeit without TSAN), and unfortunately no particular contributor stood out.

pitrou avatar Oct 26 '22 07:10 pitrou