apache
ARROW-15838: [R] Coalesce join keys in full outer join
Also:
- Added support for
keepargument in join. - Cleaned up the C++ code for the join so we directly accept the enum.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@thisisnic would you be willing to review?
I've given it a look over and other than a couple of small comments on stylistic matters, it looks good to me as nothing jumps out to me as problematic, and the tests all pass! However, I'm not at all familiar with the bit of the codebase relating to joins, and don't feel I can comment on the C++, so you may want to get someone else to give it another look over.
@nealrichardson Looks like you implemented the join bindings for R originally. Would you mind taking a look?
Benchmark runs are scheduled for baseline = 81e1fbc1dec3639f228a50282fc0a4d657c18884 and contender = ee1f76308433e377435b82d9b1ddf8e164316f16. ee1f76308433e377435b82d9b1ddf8e164316f16 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] ec2-t3-xlarge-us-east-2
[Failed :arrow_down:0.0% :arrow_up:15.56%] test-mac-arm
[Finished :arrow_down:0.54% :arrow_up:6.52%] ursa-i9-9960x
[Finished :arrow_down:0.32% :arrow_up:0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] ee1f7630 ec2-t3-xlarge-us-east-2
[Failed] ee1f7630 test-mac-arm
[Finished] ee1f7630 ursa-i9-9960x
[Finished] ee1f7630 ursa-thinkcentre-m75q
[Finished] 81e1fbc1 ec2-t3-xlarge-us-east-2
[Failed] 81e1fbc1 test-mac-arm
[Finished] 81e1fbc1 ursa-i9-9960x
[Finished] 81e1fbc1 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
