arrow icon indicating copy to clipboard operation
arrow copied to clipboard

ARROW-17394: [C++][Parquet] Fix parquet_static dependencies

Open kou opened this issue 3 years ago • 2 comments

parquet_static needs Thrift because cpp/src/parquet/thrift_internal.h uses Thrift.

See also: https://github.com/microsoft/vcpkg/issues/22552#issuecomment-1211341648

We can test this by the following command lines:

$ cd cpp/examples/parquet/parquet_arrow
$ export Arrow_DIR=${ARROW_INSTALL_PREFIX}/lib/cmake/arrow
$ export Parquet_DIR=${ARROW_INSTALL_PREFIX}/lib/cmake/arrow
$ cmake -S . -B build -DPARQUET_LINK_SHARED=OFF
$ cmake --build build --verbose

I also noticed that OpenTelemetry related dependencies are also missed because I usually use -DARROW_WITH_OPENTELEMETRY=ON option for Apache Arrow development. The problem is also fixed in this.

kou avatar Aug 12 '22 02:08 kou

https://issues.apache.org/jira/browse/ARROW-17394

github-actions[bot] avatar Aug 12 '22 02:08 github-actions[bot]

:warning: Ticket has not been started in JIRA, please click 'Start Progress'.

github-actions[bot] avatar Aug 12 '22 02:08 github-actions[bot]

Benchmark runs are scheduled for baseline = 4e48110cf4e90a4402bd0f608a4d2963015f175d and contender = 77263352843c5b44f7b59b9562e4dcd1c30cb19b. 77263352843c5b44f7b59b9562e4dcd1c30cb19b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. Conbench compare runs links: [Finished :arrow_down:0.0% :arrow_up:0.0%] ec2-t3-xlarge-us-east-2 [Failed :arrow_down:0.31% :arrow_up:0.0%] test-mac-arm [Failed :arrow_down:0.0% :arrow_up:0.0%] ursa-i9-9960x [Finished :arrow_down:0.25% :arrow_up:0.07%] ursa-thinkcentre-m75q Buildkite builds: [Finished] 77263352 ec2-t3-xlarge-us-east-2 [Failed] 77263352 test-mac-arm [Failed] 77263352 ursa-i9-9960x [Finished] 77263352 ursa-thinkcentre-m75q [Finished] 4e48110c ec2-t3-xlarge-us-east-2 [Failed] 4e48110c test-mac-arm [Failed] 4e48110c ursa-i9-9960x [Finished] 4e48110c ursa-thinkcentre-m75q Supported benchmarks: ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True test-mac-arm: Supported benchmark langs: C++, Python, R ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

ursabot avatar Aug 15 '22 09:08 ursabot

['Python', 'R'] benchmarks have high level of regressions. ursa-i9-9960x

ursabot avatar Aug 15 '22 09:08 ursabot