apisix icon indicating copy to clipboard operation
apisix copied to clipboard

docs: Add configuration docs for apisix and env variables

Open avinal opened this issue 3 years ago • 7 comments

Description

  • Added Configuration chapter
  • Added environment variables docs
  • Added docs for apisix in conf/config-default.yaml
  • Partially solves #6611

Checklist

  • [x] I have explained the need for this PR and the problem it solves
  • [x] I have explained the changes or the new features added to this PR
  • [ ] I have added tests corresponding to this change
  • [x] I have updated the documentation to reflect this change
  • [x] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Signed-off-by: Avinal Kumar [email protected]

avinal avatar Jun 16 '22 08:06 avinal

I have added all the options under apisix in the default config YAML. Please let me know if something is missing. Please review: @juzhiyuan @navendu-pottekkat @tzssangglass

avinal avatar Jun 16 '22 08:06 avinal

image

👋 Hi, please also add the missing category :)

juzhiyuan avatar Jun 16 '22 09:06 juzhiyuan

20220624-145532

The new doc is quite confusing...

For example, it is very hard to figure out that the boolean is applied to the stream_proxy.only.

Can we add the comment in a reference of yaml, like https://github.com/elastic/beats/blob/master/filebeat/filebeat.reference.yml?

spacewander avatar Jun 24 '22 07:06 spacewander

@spacewander are you suggesting that the YAML file should be updated? FYI I am working on how can I make them more obvious so that people don't get confused with other options.

avinal avatar Jun 24 '22 13:06 avinal

@spacewander are you suggesting that the YAML file should be updated? FYI I am working on how can I make them more obvious so that people don't get confused with other options.

I would suggest using a yaml code block in the doc. The yaml code will be a detailed commented version of config-default.yaml like the https://github.com/elastic/beats/blob/master/filebeat/filebeat.reference.yml

There are the benefits:

  1. straightforward
  2. easy to sync
  3. consistent render behavior

As APISIX is an open-source project, it would be great to reduce the requirement to update the doc so that contributors can update the doc themselves. Otherwise, the maintenance burden would be too heavy.

Also, a 100% mirrored config-default.yaml is easier for the users to refer to.

spacewander avatar Jun 26 '22 12:06 spacewander

I am looking into alternative methods that will be easy to maintain as well as easy to read. May take some time. Thanks

avinal avatar Jul 04 '22 10:07 avinal

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Sep 11 '22 10:09 github-actions[bot]

I apologize for the long delay, Please review. I have addressed all the comments.

avinal avatar Sep 24 '22 16:09 avinal

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Nov 25 '22 10:11 github-actions[bot]

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Dec 24 '22 10:12 github-actions[bot]