apisix icon indicating copy to clipboard operation
apisix copied to clipboard

feat: add additional handling of prometheus-cache in ngx_tpl.lua (#1212703)

Open qihaiyan opened this issue 3 months ago • 0 comments

Description

{% if enabled_plugins["prometheus"] and not enabled_stream_plugins["prometheus"] then %}
    lua_shared_dict prometheus-metrics {* http.lua_shared_dict["prometheus-metrics"] *};
    -- add prometheus-cache here
    lua_shared_dict prometheus-cache {* http.lua_shared_dict["prometheus-cache"] *};
{% end  #%}

Maybe it's better to set prometheus-cache together with prometheus-metrics in ngx_tpl.lua

Only when use_apisix_base is set to true, will the prometheus-cache take effect. But in order to integrate with QAT, i used a custom built openresty instead of apisix-runtime, so use_apisix_base is not true, and prometheus-cache is not setted in nginx.conf even if prometheus plugin is enabled.

Which issue(s) this PR fixes:

Fixes #12703

Checklist

  • [x] I have explained the need for this PR and the problem it solves
  • [x] I have explained the changes or the new features added to this PR
  • [x] I have added tests corresponding to this change
  • [ ] I have updated the documentation to reflect this change
  • [x] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

qihaiyan avatar Oct 28 '25 04:10 qihaiyan