apisix feat: allow to use environment variables for openid-connect plugin

Description

feat: allow to use environment variables for openid-connect plugin

Checklist

[x] I have explained the need for this PR and the problem it solves
[x] I have explained the changes or the new features added to this PR
[x] I have added tests corresponding to this change
[x] I have updated the documentation to reflect this change
[x] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Jul 31 '24 08:07 darkSheep404

hi good morning @shreemaan-abhishek clould you kindly review this PR for me ?

Sep 24 '24 01:09 darkSheep404

please write a test case that uses vault as well.↳ hi @shreemaan-abhishek I tried to add a test for valut but I am not sure if it is correct, may need your help to have a look

Sep 26 '24 05:09 darkSheep404

Great contribution!! I'm looking forward to this fix, as we are using AWS Secrets Manager as a secrets provider and we need to configure the secret as an environment variable. I hope this fix is merged and released soon :pray:

Oct 07 '24 16:10 alberto-corrales

the test cases for secret resource seems correct to me, please resolve the conflicts with master so that the tests can run↳

hi @shreemaan-abhishek The conflict has been resolved. Please help approve it when you are free so that can run the test

Oct 08 '24 02:10 darkSheep404

Are there any updates on this? At the moment we have to keep a secret in our repo because of the bug that it is fixing this PR, and we need to move it to environment variables. So it would be awesome if we could have this fixed in a patch soon

Dec 17 '24 13:12 alberto-corrales

Are there any updates on this? At the moment we have to keep a secret in our repo because of the bug that it is fixing this PR, and we need to move it to environment variables. So it would be awesome if we could have this fixed in a patch soon

We need another good Samaritan to approve this change, then this PR will have three approve and be merged

Dec 17 '24 13:12 darkSheep404

Are there any updates on this? At the moment we have to keep a secret in our repo because of the bug that it is fixing this PR, and we need to move it to environment variables. So it would be awesome if we could have this fixed in a patch soon

We need another good Samaritan to approve this change, then this PR will have three approve and be merged

@shreemaan-abhishek @nic-6443

Could any of you help approve this PR at your convenience? It has been pending here for a long time and only needs the last approver

Dec 17 '24 14:12 darkSheep404

Are there any updates on this? At the moment we have to keep a secret in our repo because of the bug that it is fixing this PR, and we need to move it to environment variables. So it would be awesome if we could have this fixed in a patch soon

We need another good Samaritan to approve this change, then this PR will have three approve and be merged

@shreemaan-abhishek @nic-6443

Could any of you help approve this PR at your convenience? It has been pending here for a long time and only needs the last approver

hi @kayx23 @membphis @Revolyssup Could any of you help?

Dec 24 '24 14:12 darkSheep404

I have left a comment: https://github.com/apache/apisix/pull/11451/files#r1896868940

Dec 24 '24 16:12 shreemaan-abhishek

I have left a comment: https://github.com/apache/apisix/pull/11451/files#r1896868940

i think fetch_sercets should already return a clone conf instead of modify origianl plugin_conf anyway, i just adopted your suggestion and committed the change which clone plugin_conf before fetch_sercets to avoid possible problems pls have to review at your convinence, many thanks

Dec 24 '24 17:12 darkSheep404

In addition, I noticed that two tests failed, but I don't know how to fix them. Is there anyone who is kind enough to help 😢

Jan 03 '25 08:01 darkSheep404

1th tip

=====bad style===== reindex: t/plugin/openid-connect.t: done.

echo 'you need to run '''reindex''' to fix them. Read CONTRIBUTING.md for more details.' you need to run 'reindex' to fix them. Read CONTRIBUTING.md for more details.
exit 1 make: *** [Makefile:173: lint] Error 1

2th tip

you can merge the latest master branch

Jan 08 '25 02:01 membphis

1th tip

=====bad style===== reindex: t/plugin/openid-connect.t: done.↳

echo 'you need to run '''reindex''' to fix them. Read CONTRIBUTING.md for more details.' you need to run 'reindex' to fix them. Read CONTRIBUTING.md for more details.

exit 1 make: *** [Makefile:173: lint] Error 1

2th tip

you can merge the latest master branch↳

merged latest master branch

for 1th tip, cloud you kindly help to run reindex for me ? my local windows pc no apisix source code env, we do development related to apisix use apisix offical docker image

Jan 08 '25 07:01 darkSheep404

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

Mar 24 '25 10:03 github-actions[bot]

Hi @darkSheep404, can you merge the latest master branch to trigger all the tests?

Mar 25 '25 01:03 Baoyuantop

Hi @darkSheep404, can you merge the latest master branch to trigger all the tests?

hi @Baoyuantop just merged

Mar 25 '25 02:03 darkSheep404

Hi @darkSheep404, please fix failed ci

Apr 28 '25 14:04 Baoyuantop

Hi @darkSheep404, Is there still time for this PR?

May 16 '25 08:05 Baoyuantop

Hi @darkSheep404, any updates?

Jul 03 '25 02:07 Baoyuantop

Hi @darkSheep404, any updates?

cloud you help to fix the lint issue for me? my local pc no apisix runtime now

Jul 03 '25 03:07 darkSheep404

openid-connect.t

@Baoyuantop tried to fix the lint,but i'm not sure will it works ..

Jul 03 '25 03:07 darkSheep404

seems ./utils/reindex t/plugin/openid-connect9.t works

Jul 04 '25 02:07 fengbr1

seems ./utils/reindex t/plugin/openid-connect9.t works

hi @Baoyuantop test lint issue fixed. Could help to review and approve PR ? dead ci is about mcp bridge test,this not related to this PR

Jul 04 '25 05:07 darkSheep404

Hi @darkSheep404, after re-run CI, it still fails. Can you merge the latest code from the master branch?

Jul 07 '25 01:07 Baoyuantop

Hi @darkSheep404, after re-run CI, it still fails. Can you merge the latest code from the master branch?

hi @Baoyuantop updated

Jul 07 '25 02:07 darkSheep404

hi @Baoyuantop pls help to review or approve at your convinence

Jul 14 '25 03:07 darkSheep404

Merging the latest master branch can make the failing test pass.

Jul 15 '25 03:07 Baoyuantop

Merging the latest master branch can make the failing test pass.

merged

Jul 15 '25 03:07 darkSheep404

Merging the latest master branch can make the failing test pass.

merged

by the way,i merged at last week and seems mcp-bridge test still fail after i merged lateset master branch

Jul 15 '25 03:07 darkSheep404

Hi @darkSheep404, there are still some lint errors that need to be fixed.

Jul 21 '25 10:07 Baoyuantop