apisix icon indicating copy to clipboard operation
apisix copied to clipboard

fix(grpc-transcode): filter out illegal INT(string) formats

Open zhoujiexiong opened this issue 1 year ago • 4 comments

Description

Need to sync. lua-protobuf lib. updated by this PR(https://github.com/starwing/lua-protobuf/pull/269).

Fixes #11355

Checklist

  • [x] I have explained the need for this PR and the problem it solves
  • [x] I have explained the changes or the new features added to this PR
  • [x] I have added tests corresponding to this change
  • [x] I have updated the documentation to reflect this change
  • [x] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

zhoujiexiong avatar Jun 21 '24 10:06 zhoujiexiong

Hi @yzeng25 , It seems that other test case unrelated fail the check, please help confirm.

image

zhoujiexiong avatar Jun 24 '24 03:06 zhoujiexiong

Hi @yzeng25 , It seems that other test case unrelated fail the check, please help confirm.

image

Hi @yzeng25 , Still like that, unrelated. image

zhoujiexiong avatar Jun 24 '24 09:06 zhoujiexiong

Hi @yzeng25 , It seems that other test case unrelated fail the check, please help confirm. image

Hi @yzeng25 , Still like that, unrelated. image

Let's seek help from others who are more familiar with CIs. @pottekkat @shreemaan-abhishek @nic-6443

yzeng25 avatar Jun 27 '24 08:06 yzeng25

Hi @yzeng25 , It seems that other test case unrelated fail the check, please help confirm. image

Hi @yzeng25 , Still like that, unrelated. image

Let's seek help from others who are more familiar with CIs. @pottekkat @shreemaan-abhishek @nic-6443

Checks had passed, reviewers are needed. :-) image

zhoujiexiong avatar Jun 27 '24 09:06 zhoujiexiong

@shreemaan-abhishek @nic-6443

Hi Pals, One more reviewer needed, could you help?

Ping @yzeng25 :D

zhoujiexiong avatar Jul 03 '24 11:07 zhoujiexiong