docs: Supplements the openid-connect configuration doc
This configuration is used when token introspection endpoints require additional parameters
Description
Supplements the openid-connect configuration document
Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [x] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)
Will need to add this to the schema of apisix/plugins/openid-connect.lua as well and update the English doc.
Preferably add a test case.
Will need to add this to the schema of
apisix/plugins/openid-connect.luaas well and update the English doc.Preferably add a test case.
done..
Will need to add this to the schema of
apisix/plugins/openid-connect.luaas well and update the English doc. Preferably add a test case.done..
schema is not updated? in apisix/plugins/openid-connect.lua
Will need to add this to the schema of
apisix/plugins/openid-connect.luaas well and update the English doc. Preferably add a test case.done..
schema is not updated? in
apisix/plugins/openid-connect.lua
This is not necessary. In apisix/plugins/openid-connect.lua:413 -> lua-resty-openidc/lib/resty/openidc.lua:1740, the introspection_params is already supported.
Configure the plugin like this, it works
"plugins": {
"openid-connect": {
"_meta": {
"disable": false
},
"bearer_only": true,
"client_id": "your client_id",
"client_secret": "your client_secret",
"discovery": "http://your host/.well-known/openid-configuration",
"introspection_endpoint": "http://your host/api/login/oauth/introspect",
"introspection_endpoint_auth_method": "client_secret_basic",
"introspection_params": {
"token_type_hint": "access_token"
}
}
},
Yes it will work; however introspection_params should still be added to the plugin schema. The other parameters supported by lua-resty-openidc and APISIX were also added to schema in the same way. @shreemaan-abhishek thoughts?
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.
Yes it will work; however
introspection_paramsshould still be added to the plugin schema. The other parameters supported bylua-resty-openidcand APISIX were also added to schema in the same way. @shreemaan-abhishek thoughts?
+1 on this. The reason why it works is because the parameter is passed to the fundamental library.
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.