apisix-java-plugin-runner
apisix-java-plugin-runner copied to clipboard
bug: On applying any ext-plugin-post-resp, any header set by upstream service was not passed to downstream
If we apply any ext-plugin-post-resp filter any header set by upstream service was not passed to downstream.
Also There is no provision for setting multiple headers as headers is made as private Map<String, String> headers; instead it should be private Map<String, List<String>> headers in PostResponse.java and PostRequest.java
Environment
- apisix-runner-starter 0.4.0
Minimal test code / Steps to reproduce the issue
- Apply any developed filter on ext-plugin-post-resp
- Set some header say cookie on upstream server
- Check response on httpclient, upstream headers has been ommitted
What's the actual result? (including assertion message & call stack if applicable)
Headers is not available on downstream
What's the expected result?
Headers should be available on downstream
Attaching a fix for the same apisix.zip
thx you very much. and can you create a PR ?
thx you very much. and can you create a PR ? How to do that? In which branch should I commit and push first?
Hi @abhi0476,
- You need to click
forkat https://github.com/apache/apisix-java-plugin-runner - Commit changes to the
mainbranch - Submit a PR
Hi @abhi0476,
- You need to click
forkat https://github.com/apache/apisix-java-plugin-runner- Commit changes to the
mainbranch- Submit a PR
Done