apisix-java-plugin-runner icon indicating copy to clipboard operation
apisix-java-plugin-runner copied to clipboard

bug: On applying any ext-plugin-post-resp, any header set by upstream service was not passed to downstream

Open abhi0476 opened this issue 2 years ago • 4 comments

If we apply any ext-plugin-post-resp filter any header set by upstream service was not passed to downstream.

Also There is no provision for setting multiple headers as headers is made as private Map<String, String> headers; instead it should be private Map<String, List<String>> headers in PostResponse.java and PostRequest.java

Environment

  • apisix-runner-starter 0.4.0

Minimal test code / Steps to reproduce the issue

  1. Apply any developed filter on ext-plugin-post-resp
  2. Set some header say cookie on upstream server
  3. Check response on httpclient, upstream headers has been ommitted

What's the actual result? (including assertion message & call stack if applicable)

Headers is not available on downstream

What's the expected result?

Headers should be available on downstream

Attaching a fix for the same apisix.zip

abhi0476 avatar Jul 11 '23 07:07 abhi0476

thx you very much. and can you create a PR ?

Sn0rt avatar Jul 13 '23 03:07 Sn0rt

thx you very much. and can you create a PR ? How to do that? In which branch should I commit and push first?

abhi0476 avatar Jul 13 '23 09:07 abhi0476

Hi @abhi0476,

  1. You need to click fork at https://github.com/apache/apisix-java-plugin-runner
  2. Commit changes to the main branch
  3. Submit a PR

juzhiyuan avatar Jul 14 '23 01:07 juzhiyuan

Hi @abhi0476,

  1. You need to click fork at https://github.com/apache/apisix-java-plugin-runner
  2. Commit changes to the main branch
  3. Submit a PR

Done

abhi0476 avatar Jul 14 '23 03:07 abhi0476