apisix-helm-chart icon indicating copy to clipboard operation
apisix-helm-chart copied to clipboard

[Suggestion] 添加hostPort支持

Open SRCchen opened this issue 3 years ago • 3 comments

SRCchen avatar May 30 '22 01:05 SRCchen

目前的helm chart 好像不支持hostPort ,考虑到有作为ingress使用的情况,是否可以在chart中添加hostPort 选项,具体如下:

http:
137     enabled: true
138     servicePort: 80
139     containerPort: 9080
140     hostPort: 80  # add http hostPort
141   tls:
142     enabled: false
143     servicePort: 443
144     hostPort: 443  # add tls  hostPort
145     containerPort: 9443
146     existingCASecret: ""
147     certCAFilename: ""
148     http2:
149       enabled: true

templates/daemonset.yaml or templates/daemonset.yaml

...
 52           imagePullPolicy: {{ .Values.apisix.image.pullPolicy }}
 53           ports:
 54             - name: http
 55               containerPort: {{ .Values.gateway.http.containerPort }}
 56               protocol: TCP
 57               hostPort: {{ .Values.gateway.http.hostPort }} # add http hostPort
 58             - name: tls
 59               containerPort: {{ .Values.gateway.tls.containerPort }}
 60               protocol: TCP
 61               hostPort: {{ .Values.gateway.tls.hostPort }} # add tls  hostPort
 62             {{- if .Values.admin.enabled }}
 63             - name: admin
 64               containerPort: {{ .Values.admin.port }}
 65               protocol: TCP
 66             {{- end }}
...

SRCchen avatar May 30 '22 02:05 SRCchen

@SRCchen Would you like to submit a PR? Thanks!

tokers avatar May 30 '22 09:05 tokers

@SRCchen Would you like to submit a PR? Thanks!

https://github.com/apache/apisix-helm-chart/pull/302#issue-1252553242

SRCchen avatar May 30 '22 10:05 SRCchen

Hi, may I ask when will be this feature merged?

abalage avatar Nov 16 '22 13:11 abalage

The PR is still on the going with some conflicts.

tokers avatar Nov 17 '22 10:11 tokers