amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[Improvement][OPTIMIZE]:Supports external system registration and management of Optimizer

Open hameizi opened this issue 3 years ago • 5 comments

Search before asking

  • [X] I have searched in the issues and found no similar issues.

What would you like to be improved?

now external system can't registration and management of Optimizer

How should we improve?

1.Provides interfaces for registering and unregistering Optimizers 2.Provides an interface to get the optimize Group

Are you willing to submit PR?

  • [X] Yes I am willing to submit a PR!

Code of Conduct

hameizi avatar Sep 09 '22 07:09 hameizi

I think it's a good idea! users who use arctic may have a real-time platform, optimize process may be managed by the platform for start/stop, alter.

Aireed avatar Sep 13 '22 09:09 Aireed

It seems to be a good proposal, but on what condations should we call the interface Unregistering Optimizers?

wangtaohz avatar Sep 13 '22 11:09 wangtaohz

It seems to be a good proposal, but on what condations should we call the interface Unregistering Optimizers?

In my opinion when external system drop optimizer job(but not stop optimizer job, because optimizer job maybe restart in future) that we should call Unregistering Optimizers.

hameizi avatar Sep 13 '22 11:09 hameizi

@hameizi Thanks a lot for propose this improvement and I also think that we should support external system deploy optimizer. But in my opinion, I would do it like this:

  • Start optimizer with a AMS url as argument
  • Optimizer register itself after started
  • Add an authentication mechanism if needed to help AMS validate this optimizer
  • AMS handle optimizer's life cycle with heartbeat

zhoujinsong avatar Sep 13 '22 12:09 zhoujinsong

@hameizi Thanks a lot for propose this improvement and I also think that we should support external system deploy optimizer. But in my opinion, I would do it like this:

  • Start optimizer with a AMS url as argument
  • Optimizer register itself after started
  • Add an authentication mechanism if needed to help AMS validate this optimizer
  • AMS handle optimizer's life cycle with heartbeat

I support the design, and also, only registered optimizer could poll tasks.

wangtaohz avatar Sep 13 '22 12:09 wangtaohz