amoro icon indicating copy to clipboard operation
amoro copied to clipboard

[AMORO-2438] Mixed Format KeyedTable support bin-packing splitting optimizing tasks

Open wangtaohz opened this issue 2 years ago • 1 comments

Why are the changes needed?

Close #2438 .

Brief change log

  • fix cost calculation when optimizing planning
  • split tasks by bin-packing in a tree node

How was this patch tested?

  • [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • [ ] Add screenshots for manual tests if appropriate

  • [ ] Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

wangtaohz avatar Dec 18 '23 12:12 wangtaohz

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a655ddc) 32.57% compared to head (8c18ce4) 32.59%.

Files Patch % Lines
.../server/optimizing/plan/AbstractPartitionPlan.java 91.66% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2446      +/-   ##
============================================
+ Coverage     32.57%   32.59%   +0.01%     
+ Complexity     4469     4466       -3     
============================================
  Files           599      599              
  Lines         50306    50330      +24     
  Branches       6681     6687       +6     
============================================
+ Hits          16388    16403      +15     
- Misses        32614    32622       +8     
- Partials       1304     1305       +1     
Flag Coverage Δ
core 30.75% <95.00%> (+0.01%) :arrow_up:
trino 50.36% <ø> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 18 '23 12:12 codecov[bot]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

github-actions[bot] avatar Aug 22 '24 00:08 github-actions[bot]

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Aug 29 '24 00:08 github-actions[bot]