ambari icon indicating copy to clipboard operation
ambari copied to clipboard

created a new folder named ambari-web-vite

Open 81163954 opened this issue 1 year ago • 2 comments

What changes were proposed in this pull request?

Created a new folder named ambari-web-vite in ambari-web,The goal is to use Vite to proxy Ambari Web. The process is as follows: First, use Brunch to build the public folder in Ambari Web, and then use Vite to directly start the Ambari Web project in ambari-web-vite.

81163954 avatar Jan 17 '25 12:01 81163954

@zRains Could you help review this?

JiaLiangC avatar Jan 20 '25 02:01 JiaLiangC

Thanks for your work and for providing a solid idea for developing ambari-web. However, IMO, what we need is a simple proxy server. For Vite, the ideal choice should be node-http-proxy. But in your code, you've included the initialization of a Vite project, and some of the resources there won’t actually be used—like the CSS files.

This kind of separated development environment increases debugging costs, so it’s more suitable for early, non-optimized DEV. Later on, I’d recommend replacing Brunch with Vite. This way, we can make better use of Vite’s features.

zRains avatar Jan 20 '25 14:01 zRains