ambari icon indicating copy to clipboard operation
ambari copied to clipboard

[AMBARI-25566]Fix HBase 'Mutate Latencies-Average' metric in grafana always shows 'No datapoints'

Open echohlne opened this issue 5 years ago • 5 comments

What changes were proposed in this pull request?

Now HBase does not have any performance metric starts with Mutate,The Put Metric can now be used to replace.

How was this patch tested?

manual tests I have test the metric in AMS HBase and distributed HBase, both works well

HBase shows OK AMS shows oK

echohlne avatar Oct 08 '20 08:10 echohlne

@dlysnichenko @aonishuk could you please check?

hapylestat avatar Oct 08 '20 08:10 hapylestat

@akiyamaneko in which release the Mutate metrics were removed from HBase. Do you have a jira/github commit link?

aonishuk avatar Oct 08 '20 09:10 aonishuk

@aonishuk I searched the source code of Apache HBase and the Jira website, and I finally found this:https://issues.apache.org/jira/secure/attachment/12879158/HBASE-18374.branch-1.001.patch in HBASE-18374. I think it involves the mutate metrics change:

...
@@ -330,25 +348,28 @@ public interface MetricsRegionServerSource extends BaseSource, JvmPauseMonitorSo
   String UPDATES_BLOCKED_DESC =
       "Number of MS updates have been blocked so that the memstore can be flushed.";
   String DELETE_KEY = "delete";
+  String CHECK_AND_DELETE_KEY = "checkAndDelete";
+  String CHECK_AND_PUT_KEY = "checkAndPut";
+  String DELETE_BATCH_KEY = "deleteBatch";
   String GET_SIZE_KEY = "getSize";
   String GET_KEY = "get";
   String INCREMENT_KEY = "increment";
-  String MUTATE_KEY = "mutate";
+  String PUT_KEY = "put";
   String APPEND_KEY = "append";
   String REPLAY_KEY = "replay";
   String SCAN_KEY = "scan";
   String SCAN_SIZE_KEY = "scanSize";
   String SCAN_TIME_KEY = "scanTime";
 
-  String SLOW_MUTATE_KEY = "slowPutCount";
+  String SLOW_PUT_KEY = "slowPutCount";
...

echohlne avatar Oct 08 '20 14:10 echohlne

@dlysnichenko done

echohlne avatar Oct 09 '20 17:10 echohlne

retest this please

payert avatar Mar 24 '21 16:03 payert