apache
AIP-38 Add Arabic UI translation
- While translating, I've implemented some principles currently implemented in the PR for the Hebrew translation (e.g., the term "Dag(s)" was not translated nor transliterated).
- Before merging, we might want first to adjust RTL support (see #51038).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
Nice, do we need to wait for RTL support before merging this PR?
Mostly waiting for a native speaker to go over this
Mostly waiting for a native speaker to go over this
I mean to wait for the UI to support languages written right to left. Or does it makes sense to merge it like this? (we have a PR open)
https://github.com/apache/airflow/pull/51376
Nice, do we need to wait for RTL support before merging this PR?
Yes, otherwise it would harm UX (same goes for Hebrew)
Looking into it, i will review as much as I can to merge it, but probably I will get another pr at a later date to make some more in-depth research to some terminologies
@ahmadtfarhan Thank you very much for reviewing the PR thoroughly!
I've resolved most of your comments, there are really few to settle. Everything regarding RTL alignment - we'll know better after merging the RTL PR.
Other than than - I learnt a lot from your review, and I hope that it will make it look professional and natural for native speakers. For that reason, I added you as a co-author for this PR. Would you like be mentioned as an "engaged translator" for the Arabic language? (see the role's definition in my other PR for i18n policy)
Are we in a rush? I will ask my friend if he can review it
Not at all, all RTL languages are currently on hold as there's no RTL UI support yet :) (PR is open though: https://github.com/apache/airflow/pull/51376)
I'll be happy for a 3rd opinion for unresolved comments.
@ahmadtfarhan Thank you very much for reviewing the PR thoroughly!
I've resolved most of your comments, there are really few to settle.
Everything regarding RTL alignment - we'll know better after merging the RTL PR.
Other than than - I learnt a lot from your review, and I hope that it will make it look professional and natural for native speakers.
For that reason, I added you as a co-author for this PR.
Would you like be mentioned as an "engaged translator" for the Arabic language? (see the role's definition in my other PR for i18n policy)
No worries, and thanks to you for getting ahead of me on implementing it, I had it in mind but thought of keeping it for later.
Regarding the "engaged translator", yes no problem!
@ahmadtfarhan Initial RTL support has been merged :) Would you be able to provide the extra opinion within the upcoming days? In any case, even if we merge as-is, we'll always be able to change it later.
There have been some changes in the English translation, I'll sync it during the weekend and merge
There have been some changes in the English translation, I'll sync it during the weekend and merge
Sounds good. Yes, the english translations should be more or less done after https://github.com/apache/airflow/pull/51635 is merged
@shahar1 I think we got a second opinion (@hussein-awala) and he got better suggestions for some of my translations.
@hussein-awala Thanks for your comments! I added you as a code owner and co-authored your contributions. @ahmadtfarhan I added you as an engaged translator.
Apparently there have been many changes in the English locale, and it might take me a while to translate them all as I don't have much capacity at this time (currently we're at ~30%, and it should be 100% translated before merging). If any of you want to help with translating the other terms, feel free to open a PR to this PR's branch.
feel free to open a PR to this PR's branch.
I can't seem to open a PR to your branch (never done a PR into another PR with 2 different branches in 2 different forked repos and I don't want to mess up my local repo to figure out a way around this). You can find the changes here: https://github.com/ahmadtfarhan/airflow/pull/4/files
@shahar1 Let's focus on just the translations in this PR and after it is merged @ahmadtfarhan can open a subsequent PR to fill in more translations.
feel free to open a PR to this PR's branch.
I can't seem to open a PR to your branch (never done a PR into another PR with 2 different branches in 2 different forked repos and I don't want to mess up my local repo to figure out a way around this). You can find the changes here: https://github.com/ahmadtfarhan/airflow/pull/4/files
Thanks a lot! I've committed your changes to this PR.
@shahar1 Let's focus on just the translations in this PR and after it is merged @ahmadtfarhan can open a subsequent PR to fill in more translations.
Not entirely sure that I understood. Currently it's 75% ready - do you reckon to merge it as-is and complete in later PRs?
@shahar1 yeah, that's fine. Let's just get it to 100% as soon as we can.
Fair enough, I'll do it. @jscheffl I'm aware that It exceeds the "completion before merging" policy, but I it will make it easier to handle in separate PRs to the main branch by all contributors.
CC: @hussein-awala @ahmadtfarhan