airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Recognize quotes when parsing urls in logs

Open smlee729 opened this issue 1 year ago • 4 comments


Currently, the log UI doesn't recognize single or double quotes when a url is parsed as a hyperlink, so when you click on it, you're taken to the wrong url, which is quite an inconvenient experience. I've created a PR to fix this.

^ Add meaningful description above Read the Pull Request Guidelines for more information. In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed. In case of a new dependency, check compliance with the ASF 3rd Party License Policy. In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

smlee729 avatar Jun 30 '24 16:06 smlee729

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Jun 30 '24 16:06 boring-cyborg[bot]

The regexp is a bit magic, but it does the job :)

potiuk avatar Jun 30 '24 17:06 potiuk

Need static checks fix though (recommend installing pre-commit)

potiuk avatar Jun 30 '24 17:06 potiuk

Thanks @potiuk . I found the failing test was successful :

> pre-commit run --hook-stage manual trailing-whitespace --all-files --verbose
Remove trailing whitespace at end of line................................Passed
- hook id: trailing-whitespace
- duration: 0.37s

And pushed a commit. Could you guide me how to re-trigger static-check?

smlee729 avatar Jun 30 '24 23:06 smlee729

As this is your first contribution, maintainer has to approve and run your workflow (I just did)

potiuk avatar Jul 01 '24 04:07 potiuk

Still some checks are failing. Installing pre-commit and running git commit - -amend should fix all the static checks

potiuk avatar Jul 01 '24 14:07 potiuk

I tried to run pre-commit run --all-files command, but stuck with this phase :

Run mypy for providers.............................................................Failed
- hook id: mypy-providers
- exit code: 2

Using 'uv' to install Airflow


Using airflow version from current sources


Leaving default pydantic v2


Using 'uv' to install Airflow

airflow/providers/fab/auth_manager/cli_commands/user_command.py:215: error:
f-string expression part cannot include a backslash  [syntax]
            print(f"Created the following users:\n\t{'\\n\\t'.join(users_c...
                   ^
Found 1 error in 1 file (errors prevented further checking)
Error 2 returned
If you see strange stacktraces above, and can't reproduce it, please run this command and try again:

breeze ci-image build --python 3.8

You can also run `breeze down --cleanup-mypy-cache` to clean up the cache used.

But since the change is not related to my change, I'm not sure how I can fix this issue.. Could you help me how to fix this? Other than that, I removed unused variable on my test since it complaints with ESLint.

smlee729 avatar Jul 01 '24 21:07 smlee729

Finally passed :) Yay~

smlee729 avatar Jul 01 '24 22:07 smlee729

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

boring-cyborg[bot] avatar Jul 02 '24 14:07 boring-cyborg[bot]

:tada:

potiuk avatar Jul 02 '24 14:07 potiuk