airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Fix Mark Instance state buttons stay disabled if user lacks permission (#37451)

Open RodrigoGanancia opened this issue 1 year ago • 2 comments

closes: #37451

This bug adresses a visual issue occuring when attempting to mark task states as Failed or Sucess, or when using clear button without the 'can edit on Task Instances' role. This resulted in a not expected partially empty screen in the dag menu.

The fix resolves the issue by disabling both the "Clear Task" and "Mark state as…" buttons when the user lacks permission, same as the behavior when the user can't edit on DAGs.

Now, in 'views.py', an additional meta named 'can_edit_taskintances' is passed to 'grid.html' based on the user's task instance edit permission, same as the meta 'can_edit' from user's dag edit permission defined in 'dag.html'.

Both 'canEdit' and 'canEditTaskInstances' definitions were moved inside the React components. This was necessary just for the variables to be mockable during testing, as these variables were defined before the component was loaded.

RodrigoGanancia avatar Apr 04 '24 01:04 RodrigoGanancia

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst) Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits. Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: [email protected] Slack: https://s.apache.org/airflow-slack

boring-cyborg[bot] avatar Apr 04 '24 01:04 boring-cyborg[bot]

Hey, the code is now ready, since the fix is pretty simple I removed the test case which was not needed. I'm sorry for the latest commit, It's my first time contributing and I messed up the rebase. I have already fixed it having now only one commit.

RodrigoGanancia avatar May 13 '24 11:05 RodrigoGanancia

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

boring-cyborg[bot] avatar May 31 '24 15:05 boring-cyborg[bot]