airflow icon indicating copy to clipboard operation
airflow copied to clipboard

RunID has changes

Open fokmess opened this issue 2 years ago • 17 comments

Apache Airflow version

2.5.3

What happened

When TI has cleared RunID + replace to spacebar Снимок экрана 2023-04-24 в 17 34 35

Снимок экрана 2023-04-24 в 17 35 18

What you think should happen instead

No response

How to reproduce

  1. Filter by RunID
  2. Clear Task Instance
  3. Look at RunID value

Operating System

Ubuntu 22.04.1 LTS

Versions of Apache Airflow Providers

No response

Deployment

Official Apache Airflow Helm Chart

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

fokmess avatar Apr 24 '23 14:04 fokmess

Hi, can I work on this? I am new to Apache Airflow and since it has been marked as a good first issue. I would like to give it a shot.

parth166 avatar Apr 25 '23 05:04 parth166

Sure.

potiuk avatar Apr 25 '23 14:04 potiuk

Another error that seems to be a duplicate in #30898 - @parth166 if you are still working on it, that might give you more clues on reproducibility

potiuk avatar Apr 29 '23 14:04 potiuk

Another error that seems to be a duplicate in #30898 - @parth166 if you are still working on it, that might give you more clues on reproducibility

Hey @potiuk - Yess, I was able to reproduce the error. Thanks for this - I'll use this as a hint too!

parth166 avatar Apr 30 '23 03:04 parth166

Hey @potiuk I tried to replicate this but I guess I am struggling with the codebase. Can you assign this to someone else and perhaps I can collaborate with the person to get the feel of the project and start contributing later?

parth166 avatar May 03 '23 13:05 parth166

deassigned you. Hopefully someone else will look at it

potiuk avatar May 03 '23 19:05 potiuk

Hi @potiuk , I'm able to reproduce it on main branch, I can take this one? However I'm unable to reproduce #30898 from steps its provided

herlambang avatar May 05 '23 13:05 herlambang

Assigned you - reopened the other one then, it looked the same but maybe the reason is different.

potiuk avatar May 05 '23 13:05 potiuk

I can confirm this issue is fixed on werkzeug 2.3.x, but there's dependency conflict on upgrading

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
connexion 2.14.2 requires werkzeug<2.3,>=1.0, but you have werkzeug 2.3.0 which is incompatible.

herlambang avatar May 06 '23 13:05 herlambang

Then we will have to wait for 3.0.0 of connexion https://pypi.org/project/connexion/3.0.0a6/ released 24 April with werkzeug <3. This will almost certainly mean that if there will be no errors during API tests, it will get fixed automatically by our constraints upgrades.

potiuk avatar May 06 '23 13:05 potiuk

This seems like a related werkzeug issue : https://github.com/pallets/werkzeug/issues/2657 . @fokmess Can you please confirm the version of werkzeug used and the URL before and after you hit search button?

tirkarthi avatar May 16 '23 17:05 tirkarthi

This seems like a related werkzeug issue : pallets/werkzeug#2657 . @fokmess Can you please confirm the version of werkzeug used and the URL before and after you hit search button?

Yes It is - see the comments just above yours @tirkarthi

potiuk avatar May 16 '23 18:05 potiuk

@potiuk My question was since the bug is present only on 2.3.0 (fixed in 2.3.1) and there is "connexion 2.14.2 requires werkzeug<2.3,>=1.0, but you have werkzeug 2.3.0 which is incompatible." pip resolution error. So I was just curious about the version and how they ended up in this state. Maybe that an older version of pip didn't catch this since resolver is in newer version of pip. 2.2.3 doesn't have this change and using that should also fix this issue along with being compatible.

tirkarthi avatar May 16 '23 18:05 tirkarthi

@potiuk My question was since the bug is present only on 2.3.0 (fixed in 2.3.1) and there is "connexion 2.14.2 requires werkzeug<2.3,>=1.0, but you have werkzeug 2.3.0 which is incompatible." pip resolution error. So I was just curious about the version and how they ended up in this state. Maybe that an older version of pip didn't catch this since resolver is in newer version of pip. 2.2.3 doesn't have this change and using that should also fix this issue along with being compatible.

Ah. I see that this is 2.3.0 ONLY bug. I have not seen it before - then we can simply add !=2.3.0 in airflow to fix it.

potiuk avatar May 16 '23 18:05 potiuk

(and indeed the user might be able to just downgrade it manually if they wish to)

potiuk avatar May 16 '23 18:05 potiuk

Airflow 2.5.3

❯ pip freeze | grep Werkzeug
Werkzeug==2.2.3

Also there's dependency from FAB that requires werkzeug==2.2.3 at the moment, which also becoming constrain in upgrading. Going to pull my self off from this issue as it seems would be a long waiting.

herlambang avatar May 17 '23 01:05 herlambang

This issue has been automatically marked as stale because it has been open for 365 days without any activity. There has been several Airflow releases since last activity on this issue. Kindly asking to recheck the report against latest Airflow version and let us know if the issue is reproducible. The issue will be closed in next 30 days if no further activity occurs from the issue author.

github-actions[bot] avatar May 17 '24 07:05 github-actions[bot]

This issue has been closed because it has not received response from the issue author.

github-actions[bot] avatar Jul 30 '24 07:07 github-actions[bot]