apache
Review Regression Tests
Review each regression test set and make any necessary revisions or additions.
Regression tests can be run by using the command 'make installcheck' in the incubator-age directory on your local machine.
The regression tests can be found in the /regress/sql folder. When regression tests are run, result files will be generated in /regress/results and diffed against /regress/expected. A diff file while be generated to show any differences between the expected vs actual result. Please be sure to reference these files when updating regression tests. The regression tests pass if and only if when result == expected.
It is important to check for possible uncovered test cases, and write more robust tests when necessary.
Started Reviewing sql files and also going through AGE documentation again to get better understanding of the sql commands/queries.
The queries for tests 17 and 18 in cypher_merge.sql give errors.
SELECT * FROM cypher('cypher_merge', $$CREATE (n) MERGE (n)-[:e]->() $$) AS (a agtype);
ERROR: end_id() argument must resolve to a scalar value
SELECT * FROM cypher('cypher_merge', $$CREATE (n {i : 1}) SET n.i = 2 MERGE ({i: 2}) $$) AS (a agtype);
ERROR: missing FROM-clause entry for table "_age_default_alias_0"
LINE 5: SELECT * FROM cypher('cypher_merge', $$CREATE (n {i : 1}) SE...
I think MERGE can only be used on nodes and not edges. And even if we use it on edges since 'e' is not present, MERGE is trying to create the edge and it doesn't know how to create edges without start and end id. Maybe that's the error? I am not sure. @dehowef @susano0?
Finished reviewing the files. test_expr may need to be rewritten because of the ORDER BY problems as referred to by #306
Finished reviewing all files. While installing AGE extension into PG, I found that the test expr fails only when the pg server is running in the background. When I stopped the pg server and installed it again the test expr passed successfully.
