age icon indicating copy to clipboard operation
age copied to clipboard

Reflects API changes for PG12

Open emotionbug opened this issue 3 years ago • 5 comments

emotionbug avatar Apr 14 '22 05:04 emotionbug

following functions are not wrapped yet. Same as function name. but, parameter changes. so, wrap with the word "Compat" after function.

GetSysCacheOid2
GetSysCacheOid3
CreateTemplateTupleDesc
MakeTupleTableSlot
addRangeTableEntryForRelation
ExecInitScanTupleSlot
ExecInitExtraTupleSlot
ExecInsertIndexTuples

emotionbug avatar Apr 14 '22 06:04 emotionbug

Following functions requires tts_ops

MakeTupleTableSlot
ExecInitScanTupleSlot
ExecInitExtraTupleSlot

emotionbug avatar Apr 14 '22 07:04 emotionbug

Now left some changes.

emotionbug avatar Apr 14 '22 08:04 emotionbug

follow errors will resolved on OID PR. ( #201 #194 #192 )

src/backend/catalog/ag_label.c:93:15: error: assigning to 'Oid' (aka 'unsigned int') from incompatible type 'void'
    label_oid = CatalogTupleInsert(ag_label, tuple);
              ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/backend/catalog/ag_graph.c:67:15: error: assigning to 'Oid' (aka 'unsigned int') from incompatible type 'void'
    graph_oid = CatalogTupleInsert(ag_graph, tuple);
              ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

emotionbug avatar Apr 14 '22 16:04 emotionbug

Build log with PG12, This is the end.

src/backend/catalog/ag_graph.c:67:15: error: assigning to 'Oid' (aka 'unsigned int') from incompatible type 'void'
    graph_oid = CatalogTupleInsert(ag_graph, tuple);
              ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
clang-14 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro -g -O2 -fPIC -I.//src/include -I.//src/include/parser -I. -I./ -I/home/emotionbug/pgsql12dev/include/server -I/home/emotionbug/pgsql12dev/include/internal  -D_GNU_SOURCE   -c -o src/backend/optimizer/cypher_pathnode.o src/backend/optimizer/cypher_pathnode.c
1 error generated.
make: *** [<내장>: src/backend/catalog/ag_graph.o] 오류 1
make: *** 끝나지 않은 작업을 기다리고 있습니다....
src/backend/executor/cypher_set.c:121:42: warning: variable 'saved_resultRelInfo' is uninitialized when used within its own initialization [-Wuninitialized]
    ResultRelInfo *saved_resultRelInfo = saved_resultRelInfo;;
                   ~~~~~~~~~~~~~~~~~~~   ^~~~~~~~~~~~~~~~~~~
src/backend/catalog/ag_label.c:93:15: error: assigning to 'Oid' (aka 'unsigned int') from incompatible type 'void'
    label_oid = CatalogTupleInsert(ag_label, tuple);
              ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

emotionbug avatar Apr 14 '22 20:04 emotionbug