age icon indicating copy to clipboard operation
age copied to clipboard

Seems a typo

Open deem0n opened this issue 3 years ago • 1 comments

Hi all,

I did compile the latest source on the Mac and saw a warning:

src/backend/executor/cypher_set.c:118:42: warning: variable 'saved_resultRelInfo' is uninitialized when used within its own initialization [-Wuninitialized]
    ResultRelInfo *saved_resultRelInfo = saved_resultRelInfo;;
                   ~~~~~~~~~~~~~~~~~~~   ^~~~~~~~~~~~~~~~~~~
1 warning generated. 

I think it is a typo in the src/backend/executor/cypher_set.c:118:42, please consider to apply my little fix.

deem0n avatar Mar 29 '22 07:03 deem0n

Hmm, it seems other uncommitted fix is here:

pg_catalog.pg_extension_config_dump('ag_graph', '');

it will include content of the ag_graph table into the pg_dump output. By default data in the extension controlled tables is not dumped.

deem0n avatar Mar 29 '22 08:03 deem0n

@deem0n I'm sorry for the delay here. I see that this PR has not been addressed and the issue with the code still exists. Can you be so kind as to rebase this PR to the current master? Then we can look into it more carefully.

john

jrgemignani avatar Dec 10 '22 01:12 jrgemignani

It might be more appropriate, at this point, for us to just address the issue with a patch.

jrgemignani avatar Dec 10 '22 01:12 jrgemignani

I have created a patch that gives credit to you for your work @deem0n

commit 0e96fbbf9d6cfb997b8d75da2c8dab1211915319

jrgemignani avatar Jan 05 '23 01:01 jrgemignani