age icon indicating copy to clipboard operation
age copied to clipboard

docs(golang driver): add some comments for use with GoDoc

Open mjholub opened this issue 2 years ago • 7 comments

some formatting changes were made automatically with gofumpt

mjholub avatar Jan 11 '24 16:01 mjholub

hmm perhaps writing examples could be more beneficial, made that PR because the driver felt somewhat confusing to me at first. see other database libraries on godoc for comparison, like pgx or go-sqlite3

mjholub avatar Feb 07 '24 20:02 mjholub

Though if it may cause any merge conflict with anything that changes the codebase, please just merge the code changes first and then I'd happily rebase and remove any outdated comments

mjholub avatar Feb 08 '24 12:02 mjholub

@mjholub You should be able to rebase your PR's local branch with the AGE master and then do a force push to your remote mjholub:go-driver-documentation branch. That will cause the PR to be updated and should restart all of the PR checks.

jrgemignani avatar Feb 21 '24 01:02 jrgemignani

@jrgemignani yeah I know, it appears there are no conflicts though

mjholub avatar Feb 21 '24 17:02 mjholub

@mjholub Please fill out the optional extended description with a brief (few lines) description of your changes. You will likely need to do this locally and force push it to your remote branch to update this PR.

image

jrgemignani avatar Feb 21 '24 19:02 jrgemignani

@mjholub Can you please make the update so that I can merge the PR :)

jrgemignani avatar Mar 01 '24 00:03 jrgemignani

I'll take care of it soon

mjholub avatar Mar 09 '24 02:03 mjholub

This PR is stale because it has been open 45 days with no activity. Remove "Abondoned" label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 11 '24 00:05 github-actions[bot]

This PR was closed because it has been stalled for further 7 days with no activity

github-actions[bot] avatar May 19 '24 00:05 github-actions[bot]