activemq icon indicating copy to clipboard operation
activemq copied to clipboard

[AMQ-9643] Add design doc for supporting hashed credential in PropertiesLoginModule

Open kenliao94 opened this issue 11 months ago • 2 comments

Design doc for supporting AMQ-9643

kenliao94 avatar Feb 26 '25 00:02 kenliao94

I would suggest to mimic what I did in Apache Karaf (https://github.com/apache/karaf/blob/main/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/encryption/EncryptionSupport.java). Basically, I have on thread that scan the properties file, and if it detects non encrypted password (e.g without the prefix), then it does the encryption and "flag" the password with the prefix (indicating it's a hash).

jbonofre avatar Mar 05 '25 17:03 jbonofre

I would suggest to mimic what I did in Apache Karaf (https://github.com/apache/karaf/blob/main/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/encryption/EncryptionSupport.java). Basically, I have on thread that scan the properties file, and if it detects non encrypted password (e.g without the prefix), then it does the encryption and "flag" the password with the prefix (indicating it's a hash).

Hey @jbonofre thanks for the review. I am not following. If a password doesn't have the prefix, then we assume it is just plaintext.

kenliao94 avatar Mar 19 '25 21:03 kenliao94