activemq icon indicating copy to clipboard operation
activemq copied to clipboard

[AMQ-8324] Add design doc for Jakarta Messaging 3.1 asynchronous send

Open kenliao94 opened this issue 11 months ago • 5 comments

Add design doc for implementing Jakarta Messaging 3.1 asynchronous send per the latest process discussed on dev list.

Note to reviewers, GitHub rich diff doesn't render image properly. You can click "view file" from the hamburger button to see the rendered markdown.

kenliao94 avatar Feb 19 '25 07:02 kenliao94

I don't really like the use of images as they are not easily modifiable. Markdown supports code blocks (and you can mark it as java) so I would use something like that instead.

cshannon avatar Feb 24 '25 13:02 cshannon

Image is fine for design diagram/schema. However, it should not be used for code. Instead we should use the markdown code block: the huge advantage is that we can suggest change during the review.

+1 for this

cshannon avatar Feb 24 '25 13:02 cshannon

Thanks @cshannon and @jbonofre for the feedback, I will use code block instead. Hoping to publish a new revision tmr.

kenliao94 avatar Feb 25 '25 06:02 kenliao94

Use codeblock instead of image.

kenliao94 avatar Feb 25 '25 23:02 kenliao94

I haven't had a chance to get back to looking at this yet but still plan to, @mattrpav have you had a change to review this yet?

cshannon avatar Mar 17 '25 21:03 cshannon