al-code-outline icon indicating copy to clipboard operation
al-code-outline copied to clipboard

Fields selection is not working anymode

Open mihaivalceaCPS opened this issue 1 year ago • 17 comments

Hi,

I cannot select and add fields to page. After I check a field in fields list the check mark si automatically disabled.

Regards, Mihai

mihaivalceaCPS avatar Aug 06 '24 05:08 mihaivalceaCPS

I am experiencing same issue also.

barandeniz avatar Aug 06 '24 10:08 barandeniz

I found this in the VS Code repository: https://github.com/microsoft/vscode/issues/223363

pri-kise avatar Aug 08 '24 07:08 pri-kise

Just to let you know, same issue here for the last couple of weeks. First I wasn't able to select fields like the issue starter. Now, the whole selections screen won't appear anymore.

erikrijn avatar Aug 12 '24 12:08 erikrijn

The issue still exists and maybe un update is required.

From: Erik van Rijn @.> Sent: Monday, August 12, 2024 3:05 PM To: anzwdev/al-code-outline @.> Cc: mihaivalceaCPS @.>; Author @.> Subject: Re: [anzwdev/al-code-outline] Fields selection is not working anymode (Issue #603)

Just to let you know, same issue here for the last couple of weeks.

— Reply to this email directly, view it on GitHub https://github.com/anzwdev/al-code-outline/issues/603#issuecomment-2283789227 , or unsubscribe https://github.com/notifications/unsubscribe-auth/BKLATA6JB3JISR3NJB3XIKDZRCQHNAVCNFSM6AAAAABMBSPVG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBTG44DSMRSG4 . You are receiving this because you authored the thread. https://github.com/notifications/beacon/BKLATA4GAKTZRMXU6ZCJE6DZRCQHNA5CNFSM6AAAAABMBSPVG6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUID7N2W.gif Message ID: @.*** @.***> >

mihaivalceaCPS avatar Aug 12 '24 12:08 mihaivalceaCPS

It is broken in the latest version of VS Code. I am checking if it is a bug or vs code api change.

anzwdev avatar Aug 12 '24 19:08 anzwdev

The issue was caused by changes to the vs code api. One of the properties of pick list items that were ignored in the previous versions needs to be set now. I've released a new version of the extension, problem should be solved now.

anzwdev avatar Aug 12 '24 22:08 anzwdev

@anzwdev after update to v14.0.956192 (pre-release) still not works. Tested on PageExt and Pages. Still impossble to "check" the checkbox. VSCode: Version: 1.92.1 (system setup) Commit: eaa41d57266683296de7d118f574d0c2652e1fc4 Date: 2024-08-07T20:16:39.455Z Electron: 30.1.2 ElectronBuildId: 9870757 Chromium: 124.0.6367.243 Node.js: 20.14.0 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0.19045

alan0z avatar Aug 13 '24 06:08 alan0z

@alan0z Try version 13.70.0 (non prerelease)

dannoe avatar Aug 13 '24 07:08 dannoe

For me it isn't working with the latest version. I installed the version v13.70.0 of the extension and closed all VS Code windows.

VS Code: Version: 1.92.1 (user setup) Commit: eaa41d57266683296de7d118f574d0c2652e1fc4 Date: 2024-08-07T20:16:39.455Z

pri-kise avatar Aug 13 '24 10:08 pri-kise

It also still isn't working on my end. Even with the latest version.

sofiaagmp avatar Aug 13 '24 11:08 sofiaagmp

@alan0z Try version 13.70.0 (non prerelease)

The same result :(

alan0z avatar Aug 13 '24 11:08 alan0z

As a temporary workaround you can search for the following file:

C:\Users\<username>\.vscode\extensions\andrzejzwierzchowski.al-code-outline-13.70.0\out\codeactions\addFields\tableFieldsSelector.js

And comment out line 121:

//this._quickPick.items = newItems;

The sorting after selected items isn't working with this, but at least it is usable. This change will be lost if you install a new version.

dannoe avatar Aug 13 '24 13:08 dannoe

As a temporary workaround you can search for the following file:

C:\Users\<username>\.vscode\extensions\andrzejzwierzchowski.al-code-outline-13.70.0\out\codeactions\addFields\tableFieldsSelector.js

And comment out line 121:

//this._quickPick.items = newItems;

The sorting after selected items isn't working with this, but at least it is usable. This change will be lost if you install a new version.

I tried this and still doesn't let me select anything.

sofiaagmp avatar Aug 13 '24 14:08 sofiaagmp

I tried this and still doesn't let me select anything.

Did you reload or restart vscode after changing the file? Is your current active version of the al-code-outline extension 13.70.0?

dannoe avatar Aug 13 '24 14:08 dannoe

I tried this and still doesn't let me select anything.

Did you reload or restart vscode after changing the file? Is your current active version of the al-code-outline extension 13.70.0?

Tried again and it is working. Thank you!

sofiaagmp avatar Aug 13 '24 14:08 sofiaagmp

I've found what was wrong. The latest version of VS Code triggers quick pick events in a different way. New version is ready, it should work for you now.

anzwdev avatar Aug 14 '24 18:08 anzwdev

I updated my VS Code today.

Version: 1.92.2 (user setup) Commit: fee1edb8d6d72a0ddff41e5f71a671c23ed924b9 Date: 2024-08-14T17:29:30.058Z

and now it's working again with version v13.71.0.

pri-kise avatar Aug 21 '24 11:08 pri-kise