Permits to use doorcat on Entreprise Github instance

[edimitchel]

Hi @antfu !

I'm working with a self-hosted Enterprise Github instance, is it possible to configurate the endpoint? Instead of github.com, use the custom domain. And this could be a parameter of the webex.

What I see for the moment that should be being customized: https://github.com/antfu/github-doorcat/blob/main/src/background/contentScriptHMR.ts#L13 https://github.com/antfu/github-doorcat/blob/main/src/contentScripts/fetch.ts#L15 https://github.com/antfu/github-doorcat/blob/main/src/contentScripts/fetch.ts#L20

[edimitchel]

I'll give a try by cloning the repo and try it in dev mode

[antfu]

Could do, but I am mostly concerned about that if Chrome Store allows that 🤔

[edimitchel]

And using the Options page ?

[antfu]

The problem here is the extension permission, which need to be included in the manifest statically, while have */ could make the reviewing much harder.

[edimitchel]

Yes, understood.. :/ And what if it includes github inside the url ?

[antfu]

I see there might be a solution here:

• https://github.com/sindresorhus/refined-github/blob/32abfaaa4696053fa956f12b0186339e80f19292/distribution/manifest.json#L25-L27
• https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/optional_permissions
• https://github.com/sindresorhus/refined-github/issues/3543

While I don't have access to a GitHub Enterprise instance, I will need to leave this to you to test out and sending a PR.

[edimitchel]

The package webext-domain-permission-toggle permits it, I will try that