bumpp icon indicating copy to clipboard operation
bumpp copied to clipboard

`bump.config.ts` has no effect on `commit` and `tag`

Open chrisspiegl opened this issue 2 years ago • 0 comments

Describe the bug

The settings for commit and tag appear to be completely ignored when set to false or even when set to a string (e.g. jumpy or ju-%s-py). Docs say that these should be used for naming the version (when string used) or to disable tag and commit respectively.

The only one that appears to be working is push: false which actually prevents the git push.

I did not test the all: false/true or execute parameter.

Test Results:

bumpp-v9.1.0-bump.config.ts

  • finds bump.config.ts
  • does not respect any of the parameters except push: false
  • it also actually tries to commit/tag/etc.

bumpp-v9.2.0-bump.config.ts

  • finds bump.config.ts
  • does not respect any of the parameters except push: false
  • commit and tag are ignored if set to false or if seet to a string e.g. jumpy or ju-%s-py
  • it also actually tries to commit/tag/etc.

Reproduction

https://codesandbox.io/p/sandbox/reproduction-bumpp-config-file-jywcm5

System Info

System:
    OS: macOS 14.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 21.90 GB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.18.2 - ~/Library/pnpm/node
    pnpm: 8.9.2 - ~/Library/pnpm/pnpm

Used Package Manager

pnpm

Validations

  • [X] Follow our Code of Conduct
  • [X] Read the Contributing Guide.
  • [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • [X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
  • [X] The provided reproduction is a minimal reproducible of the bug.

chrisspiegl avatar Oct 18 '23 16:10 chrisspiegl