monument icon indicating copy to clipboard operation
monument copied to clipboard

Experiment with ejs template

Open designfrontier opened this issue 9 years ago • 5 comments

Using the config object changes and the render changes from #292 #291 run a site using ejs and see if there are things that need to be changed.

Also look at whether autodetection of the engine and if there are defaults that make sense if we can autodetect

Part of this ticket should be creating documentation around using ejs and adding examples for how to use ejs with monument

designfrontier avatar Oct 25 '16 15:10 designfrontier

Hi, I would like to try and work out this issue. Since I'm a first time contributor is there anything that I should keep in mind while handling this? As of now this is my understanding of the problem -

  • Add a template object in the global config object to provide configuration for templating engine which by default is going to be dotJs (Eg. ejs/jade)
  • Check if each render engine functions properly

Sorry if this approach seems a bit over simplified.

ExC0d3 avatar Nov 25 '16 09:11 ExC0d3

Yeah that approach sounds pretty good. I have a branch up where I am working on getting the render items pulled into the config that you pass into the server. I am 90% of the way there (https://github.com/ansble/monument/pull/301) just have some failing tests to get squared away. But looking through that may give you some more insight.

I am hoping to find sometime this weekend to get that change finished up and merged into the next release branch.

You can probably start working with that branch as your base.

designfrontier avatar Nov 25 '16 14:11 designfrontier

That branch being this one: https://github.com/ansble/monument/tree/feature/swappable-template-engines-add-config-objects

designfrontier avatar Nov 25 '16 14:11 designfrontier

also the config object would include the template engine itself, so the ejs engine as well as any config that it needs.

designfrontier avatar Nov 25 '16 14:11 designfrontier

If you start from the Strade Bianchi branch you should be able to make a run at it now. Got the config object pull request merged over the weekend

On Fri, Nov 25, 2016 at 2:34 AM, Abhinav Sharma [email protected] wrote:

Hi, I would like to try and work out this issue. Since I'm a first time contributor is there anything that I should keep in mind while handling this? As of now this is my understanding of the problem -

  • Add a template object in the global config object to provide configuration for templating engine which by default is going to be dotJs (Eg. ejs/jade)
  • Check if each render engine functions properly

Sorry if this approach seems a bit over simplified.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ansble/monument/issues/297#issuecomment-262915961, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZyjJX8bQxVJCKWdrnquoXVkIc_YaG-ks5rBquagaJpZM4KgJNU .

designfrontier avatar Dec 01 '16 03:12 designfrontier