opencode icon indicating copy to clipboard operation
opencode copied to clipboard

feat: add bluloco theme

Open uloco opened this issue 1 week ago • 5 comments

What does this PR do?

Add bluloco theme

How did you verify your code works?

I just added it where other themes reside, I did not test it in this branch actually. But i tested it locally as a custom theme. If I should test it still, let me know, ty.

fixes #8653

uloco avatar Jan 15 '26 10:01 uloco

Hey! Your PR title Add bluloco theme doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

github-actions[bot] avatar Jan 15 '26 10:01 github-actions[bot]

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

github-actions[bot] avatar Jan 15 '26 10:01 github-actions[bot]

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

github-actions[bot] avatar Jan 15 '26 10:01 github-actions[bot]

Code review

Found 1 issue:

  1. Theme not registered in theme.tsx - missing import and DEFAULT_THEMES entry

The bluloco.json file was added but is not imported or registered in packages/opencode/src/cli/cmd/tui/context/theme.tsx. Without registration, the theme will not appear in the theme list and cannot be selected by users.

Evidence: All previous theme additions modified theme.tsx to:

  • Add an import statement (around line 6-37): import bluloco from "./theme/bluloco.json" with { type: "json" }
  • Add to DEFAULT_THEMES object (around line 140-173): bluloco,

Examples from git history:

  • Osaka theme (commit 268de2a3): https://github.com/anomalyco/opencode/commit/268de2a3d9bb5d31766b6e9fae6e3a2fc3c8754e
  • Vercel theme (commit ada7cca10): https://github.com/anomalyco/opencode/commit/ada7cca109a88e45fb643239c6c0788c3be4b8c6

Required fix: Modify packages/opencode/src/cli/cmd/tui/context/theme.tsx to:

  1. Add import: import bluloco from "./theme/bluloco.json" with { type: "json" }
  2. Add to DEFAULT_THEMES: bluloco,

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

LIHUA919 avatar Jan 15 '26 14:01 LIHUA919