Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

No confirmation dialog after editing the card browser appearance or deck override

Open ZornHadNoChoice opened this issue 7 months ago • 19 comments

[!IMPORTANT] This issue is to be included in a research study, and should not be worked on

Checked for duplicates?

  • [x] This issue is not a duplicate

Does it also happen in the desktop version?

  • [x] This bug does not occur in the latest version of Anki Desktop

What are the steps to reproduce this bug?

  1. Go to manage note types.
  2. Tap on edit cards on a note type.
  3. Tap the 3 dot button.
  4. Tap on card browser appearance and type something.
  5. Alternatively, tap deck override and chose a deck.
  6. Leave the note editor.

Expected behaviour

A confirmation dialog shows up.

Debug info

AnkiDroid Version = 2.21alpha18 (5464fe94fefe937fd7eca143805eec18cecde9f3)
Backend Version = 0.1.52-anki25.02.7 (25.02.7 98253c81cb3c4d203acec48d6eae6b488bf484d0)
Android Version = 13 (SDK 33)
ProductFlavor = full
Device Info = Xiaomi | POCO | mondrian | mondrian_global | 23013PC75G | qcom
Webview User Agent = Mozilla/5.0 (Linux; Android 13; 23013PC75G Build/TKQ1.220905.001; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/137.0.7151.61 Mobile Safari/537.36
ACRA UUID = b9d03d9a-5af9-4e67-987e-cc15799171e2
FSRS = 2.0.3 (Enabled: true)
Crash Reports Enabled = true

(Optional) Anything else you want to share?

Edit: I noticed that the same is true for adding, renaming or deleting a card type (renaming card types doesn't trigger a confirmation dialog in Anki Desktop).

Research

  • [x] I have checked the manual and the FAQ and could not find a solution to my issue
  • [x] (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)

ZornHadNoChoice avatar Jun 14 '25 20:06 ZornHadNoChoice

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

github-actions[bot] avatar Sep 15 '25 12:09 github-actions[bot]

Still exists in v2.23.0alpha4.

ZornHadNoChoice avatar Sep 15 '25 13:09 ZornHadNoChoice

Hey @david-allison can i contribute to this issue?

sidharth6761 avatar Sep 29 '25 14:09 sidharth6761

Sure, thanks!

david-allison avatar Sep 29 '25 14:09 david-allison

@david-allison i guess this issue is already resolved , kindly check once.

sidharth6761 avatar Sep 29 '25 15:09 sidharth6761

It's not fixed

AnkiDroid Version = 2.23.0alpha0-debug (a1c980b00bb2a36cfd2c8618a3caf983006d5068)
Backend Version = 0.1.60-anki25.07.5 (25.07.5 7172b2d26684c7ef9d10e249bd43dc5bf73ae00c)
Android Version = 16 (SDK 36)
ProductFlavor = full
Device Info = Google | google | caiman | caiman | Pixel 9 Pro | caiman
Webview User Agent = Mozilla/5.0 (Linux; Android 16; Pixel 9 Pro Build/BP3A.250905.014; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/140.0.7339.155 Mobile Safari/537.36
ACRA UUID = f15ede14-140e-4890-bb11-8f07bdb64a05
FSRS = 4.1.1 (Enabled: true)
Crash Reports Enabled = false

david-allison avatar Sep 29 '25 15:09 david-allison

You need to press the back arrow button or your systems method of navigating back.

ZornHadNoChoice avatar Sep 29 '25 15:09 ZornHadNoChoice

@ZornHadNoChoice Kindly share a screen recording of the issue for better resolvment.

sidharth6761 avatar Sep 29 '25 15:09 sidharth6761

https://github.com/user-attachments/assets/ee1737a5-3893-4b74-8f2d-62e5b6ed4a2d

ZornHadNoChoice avatar Sep 29 '25 19:09 ZornHadNoChoice

@ZornHadNoChoice i see the issue now. Expected behaviour is that it should show a confirmation dialogue box to save the changes . Right? kindly clarify if i have been mistaken .

sidharth6761 avatar Sep 30 '25 07:09 sidharth6761

Yes. It should look like this:

Image

ZornHadNoChoice avatar Sep 30 '25 07:09 ZornHadNoChoice

@david-allison i dont understand this is already there in the codebase when we navigate back from the editor , the confirmation box pops up but the application in playstore doesnt do so . Is the app not updated in the playstore? I went through the repo and everything seems fine . Please confirm

https://github.com/user-attachments/assets/40813743-0d25-48f0-b089-9cae854fec00

sidharth6761 avatar Sep 30 '25 08:09 sidharth6761

I'll confirm in the latest alpha, please ping me if I haven't responded within 3 hours

david-allison avatar Sep 30 '25 09:09 david-allison

@david-allison please confirm

sidharth6761 avatar Sep 30 '25 14:09 sidharth6761

Still reproducible

david-allison avatar Sep 30 '25 17:09 david-allison

Hi, could I be assigned this issue?

ShaanNarendran avatar Dec 06 '25 18:12 ShaanNarendran

Hi, we're saving this one for a research study, so it shouldn't be worked on

david-allison avatar Dec 06 '25 18:12 david-allison

Hi, we're saving this one for a research study, so it shouldn't be worked on

Ah ok, I had actually just added a line to the code which fixed the issue of the dialog box not showing up when a user does a deck override and tries to exit without saving it. As far as I saw in the newest version, the app just lets you exit the edit screen after doing the override but after that change the dialog box does show up. Should I post that change?

ShaanNarendran avatar Dec 06 '25 18:12 ShaanNarendran

With apologies, please don't.

This one is my responsibility, and I profusely apologize for the overight.

We were contacted by a researcher from Stanford in late October regarding a study, and they requested a number of issues to be tagged for evaluation.

I didn't get around to marking these issues as 'assigned'

david-allison avatar Dec 06 '25 18:12 david-allison