ankidroid
Fixed bug which was causing AnkiDroid API to not list media on cards.
Purpose / Description
Fixed the bug which was causing AnkiDroid API to not list media on cards. Added a unit test to confirm that media files are listed correctly in the ReviewInfo.
Fixes
- Fixes #17062
Approach
Reimplemented the filesinStr function which was causing the bug.
How Has This Been Tested?
A unit test testMediaFilesAddedCorrectlyInReviewInfo() has been added in the ContentProviderTest.kt to confirm that the MEDIA_FILES attribute of ReviewInfo gets populated correctly.
Checklist
Please, go through these checks before submitting the PR.
- [x] You have a descriptive commit message with a short title (first line, max 50 chars).
- [x] You have commented your code, particularly in hard-to-understand areas
- [x] You have performed a self-review of your own code
- [x] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
- [x] UI Changes: You have tested your change using the Google Accessibility Scanner
First PR! š We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.
![welcome[bot] avatar](https://avatars.githubusercontent.com/in/4141?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello š, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I feel like we were close here but both David and I have been really busy, apologies for the default-stale-close Will reopen to give another chance for @ujjol1234 to advance the comments under discussion
Hello š, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically
It feels like this is still pending comments @ujjol1234 is this correct?
Hello š, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically
Hi @david-allison, apologies for the delayed response ā I had semester exams going on. Iām back now and will be able to contribute consistently moving forward!
No worries! I've taken this to the finish line and added a decent amount more issues
Thanks so much for the hard work here