Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

[BUG]: Card Browser - Toggle Notes -> Changing deck in Note Editor only modifies one card

Open Hyoogen-no-Kachi opened this issue 1 year ago • 11 comments

Checked for duplicates?

  • [x] This issue is not a duplicate

Does it also happen in the desktop version?

  • [x] This bug does not occur in the latest version of Anki Desktop

What are the steps to reproduce this bug?

  1. Create 2 decks, Test 1 and Test 2
  2. Create a cloze note e.g. {{c1::Hello}} {{c2::World}}! in the Test 1 deck
  3. Go to the Card Browser on AnkiDroid, click on the 3 dots, click on Options, and set Toggle Notes
  4. Search for Hello World! on the search bar.
  5. If you notice, when you click in the arrow and change Sort Field to Question, only one card will appear.
  6. ⚠️ Click on the note/card and change the deck from Test 1 to Test 2.
  7. Now, if you go back to the main screen or you go back to the Card Browser and set Toggle Cards again, you’ll see that only one card changed deck.

Expected behaviour

  1. I expected to change all cards of the notes of its original deck at once
  2. I expected that the decks name of the cards on the browser desktop would be the name I setted, and not (1) or (2)

Debug info

AnkiDroid Version = 2.18.4 (f867da96b8304edaebd0361326316bc7514f8cde)

Backend Version = 0.1.38-anki24.04.1 (24.04.1 ccd9ca1a8309b80bcb50ddc5d99c7ce63440bce9)

Android Version = 13 (SDK 33)

ProductFlavor = play

Manufacturer = samsung

Model = SM-A226BR

Hardware = mt6833

Webview User Agent = Mozilla/5.0 (Linux; Android 13; SM-A226BR Build/TP1A.220624.014; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/130.0.6723.86 Mobile Safari/537.36

ACRA UUID = d549ca88-5110-4f4d-9b75-1f1552dc6095

FSRS Enabled = true

Crash Reports Enabled = true

(Optional) Anything else you want to share?

Reported here https://forums.ankiweb.net/t/bug-report-notes-arent-in-the-deck-where-they-supposed-to-be/51355/6

In it there is more context

Research

  • [x] I have checked the manual and the FAQ and could not find a solution to my issue
  • [x] (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)

Hyoogen-no-Kachi avatar Nov 10 '24 22:11 Hyoogen-no-Kachi

Hello! 👋 Thanks for logging this issue. Please remember we are all volunteers here, so some patience may be required before we can get to the issue. Also remember that the fastest way to get resolution on an issue is to propose a change directly, https://github.com/ankidroid/Anki-Android/wiki/Contributing

welcome[bot] avatar Nov 10 '24 22:11 welcome[bot]

Thanks for the report! Could you check with 2.19, as that includes a number of bugfixes

  • https://github.com/ankidroid/Anki-Android/releases/latest - Parallel.A

david-allison avatar Nov 10 '24 22:11 david-allison

I just checked some old issues and these ones are similar:

  1. https://github.com/ankidroid/Anki-Android/issues/14857
  2. https://github.com/ankidroid/Anki-Android/issues/15444

But they are before the june update of AnkiDroid and the problem is the issue I mentioned is still going on:

  • When change the deck on browser using Toogle Notes only one card changes deck, and not all of them
  • I expected to change it all at once just as Anki Desktop browser does, and when it changes the deck, in the browser screen on Anki Desktop browser it doesn't appear with its deck name)

I know I can just use Toggle Cards instead, but I wanted to help by reporting this unexpected issue

Hyoogen-no-Kachi avatar Nov 10 '24 23:11 Hyoogen-no-Kachi

Can you confirm that the bug still exists in the 2.19.1 release?

david-allison avatar Nov 11 '24 00:11 david-allison

@david-allison I just downloaded the 2.19.1 and did the same steps, and yes, both issues still are in it Image Image

Hyoogen-no-Kachi avatar Nov 11 '24 00:11 Hyoogen-no-Kachi

Can't reproduce. Could you provide a sample video using AnkiDroid 2.19.1 Parallel.A:

https://github.com/ankidroid/Anki-Android/releases/download/v2.19.1/AnkiDroid-2.19.1.parallel.A.apk

david-allison avatar Nov 12 '24 14:11 david-allison

@david-allison I uploaded a video to YouTube showing how to replicate the bug in this version you mentioned

(I recommend you to watch on 2x speed since I spoke too slowly)

Hyoogen-no-Kachi avatar Nov 13 '24 21:11 Hyoogen-no-Kachi

Ref:

https://github.com/ankidroid/Anki-Android/blob/eb9dd9782cb3a36a708e32634202f71a713be606/AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.kt#L866-L876

The above must handle multiselect and NOTES mode.

For now it only handles multiselect.

The Note Editor may also want to be modified to handle an edit of a Note, rather than a Card

david-allison avatar Nov 13 '24 21:11 david-allison

Can you assign this to me?

SttApollo avatar Nov 23 '24 22:11 SttApollo

Sure

david-allison avatar Nov 24 '24 00:11 david-allison

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

github-actions[bot] avatar Mar 04 '25 16:03 github-actions[bot]

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

github-actions[bot] avatar Sep 08 '25 11:09 github-actions[bot]