Added multiselect delete in manageNotesType

[jainv4156]

Added Multiselect delete in manageNoteType

Purpose / Description

Describe the problem or feature and motivation

Fixes

• Fixes #15885

Checklist

Please, go through these checks before submitting the PR.

• [x] You have a descriptive commit message with a short title (first line, max 50 chars).
• [x] You have commented your code, particularly in hard-to-understand areas
• [x] You have performed a self-review of your own code
• [x] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• [ ] UI Changes: You have tested your change using the Google Accessibility Scanner

Screencast from 2024-09-19 12-33-39.webm

After Changes

• disabled edit card , rename ,delete
• pressing back button will disable multiSelect mode rather then nevigating up

Screencast from 2024-09-22 23-08-54.webm

[brishtibheja]

I think the current delete option shouldn't be there. It's weird that we have the same functionality twice. Also, it makes me anxious when the delete option (a high-risk option) is very easy to reach.

Perhaps, long-press then delete can become the default, maintainers?

[jainv4156]

you got a point. We can disable the delete option while in multiSelect mode or we can completely remove the default delete button

and there is one more problem. When we long press and multiselct mode enables, the other functionalities like add ,rename ,edit are still accessible. so should we disable them too ?

[brishtibheja]

I'd say yes, remove all but you may want to wait for the maintainers' opinions.

[sanjaysargam]

so should we disable them too ?

Yes, we should disable at least rename, edit, delete

When the user is in multiselect mode and presses the back button, instead of navigating back to the previous screen (DeckPicker screen), the multiselect mode should be exited. The back button press should act as a trigger to clear the current selection and exit the multiselect state, keeping the user on the same screen

[sanjaysargam]

Another issue: The checkbox is not being displayed for all note types

[jainv4156]

Another issue: The checkbox is not being displayed for all note types

this is due to adding the new selected note type while in multiselect mode . so should i disable it too or fix this issue

[sanjaysargam]

this is due to adding the new selected note type

That's not the case. To reproduce, have more than 5-10 note types, enable multiselect mode and scroll down

should i disable it too or fix this issue

should fix

[jainv4156]

this is due to adding the new selected note type

That's not the case. To reproduce, have more than 5-10 note types, enable multiselect mode and scroll down

should i disable it too or fix this issue

should fix

ok , I'll check and correct it

[sanjaysargam]

close button should be at the right most corner.

[david-allison]

   > KtLint found code style violations. Please see the following reports:
     - /home/runner/work/Anki-Android/Anki-Android/AnkiDroid/build/reports/ktlint/ktlintMainSourceSetCheck/ktlintMainSourceSetCheck.txt

In addition, please rebase/squash and force push, rather than adding merge commits to the history

[jainv4156]

i'll fix that

[github-actions[bot]]

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

[sanjaysargam]

@jainv4156 tests fails

[david-allison]

It's stale & that comment reset the stale bot for a few weeks

Reopen if it can be moved to a fixable state